All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3: Use sdelay from arch/arm/cpu/armv7/syslib.c instead of cloning that.
Date: Sun, 19 Dec 2010 08:54:46 +0100	[thread overview]
Message-ID: <4D0DBA46.8020505@googlemail.com> (raw)
In-Reply-To: <1292675060-3971-1-git-send-email-holler@ahsoftware.de>

On 18.12.2010 13:24, Alexander Holler wrote:
> There is no need to have such a function twice.
>
> Signed-off-by: Alexander Holler<holler@ahsoftware.de>
> ---
>   arch/arm/cpu/armv7/omap3/board.c |   12 +-----------
>   1 files changed, 1 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/omap3/board.c b/arch/arm/cpu/armv7/omap3/board.c
> index 6c2a132..0e62626 100644
> --- a/arch/arm/cpu/armv7/omap3/board.c
> +++ b/arch/arm/cpu/armv7/omap3/board.c
> @@ -41,16 +41,6 @@
>   extern omap3_sysinfo sysinfo;
>
>   /******************************************************************************
> - * Routine: delay
> - * Description: spinning delay to use before udelay works
> - *****************************************************************************/
> -static inline void delay(unsigned long loops)
> -{
> -	__asm__ volatile ("1:\n" "subs %0, %1, #1\n"
> -			  "bne 1b":"=r" (loops):"0"(loops));
> -}
> -
> -/******************************************************************************
>    * Routine: secure_unlock
>    * Description: Setup security registers for access
>    *              (GP Device only)
> @@ -189,7 +179,7 @@ void s_init(void)
>   		setup_auxcr();
>
>   	set_muxconf_regs();
> -	delay(100);
> +	sdelay(100);
>
>   	prcm_init();
>

Looking at the implementation of sdelay(), yes, it seems it's just an 
identical copy of delay(). So:

Acked-by: Dirk Behme <dirk.behme@googlemail.com>

Thanks

Dirk

  reply	other threads:[~2010-12-19  7:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18 12:24 [U-Boot] [PATCH] OMAP3: Use sdelay from arch/arm/cpu/armv7/syslib.c instead of cloning that Alexander Holler
2010-12-19  7:54 ` Dirk Behme [this message]
2011-11-18 23:16 ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0DBA46.8020505@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.