All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm1136: timer: Replace bss variable by gd
Date: Sun, 19 Dec 2010 09:45:32 +0100	[thread overview]
Message-ID: <4D0DC62C.6000303@denx.de> (raw)
In-Reply-To: <20101217201304.18F3FB19C@gemini.denx.de>

Hello Wolfgang,

Wolfgang Denk wrote:
> Dear Albert & Heiko,
> 
> In message <4D01E031.3090100@free.fr> you wrote:
>>> Reuse the gd->tbl value for timestamp and add gd->lastinc for lastinc bss
>>> values in the arm1136 timer driver for mx31 and omap24xx
>>>
>>> The usage of bss values in drivers before initialisation of bss is forbid> den.
>>> In that special case some data in .rel.dyn gets corrupted.
>>>
>>> This patch is similiar to the patch Dirk Behme posted
>>> for the armv7/omap-common/timer.c
>>>
>>> Tested on the mx31 based qong board
>>>
>>> Signed-off-by: Heiko Schocher<hs@denx.de>
>>> cc: Albert ARIBAUD<albert.aribaud@free.fr>
>> FWIW,
>>
>> Acked-by: Albert ARIBAUD <albert.aribaud@free.fr>
> 
> Should I pull this into v2010.12, or should we rather wait for amore
> general solution and fix it in the next release?

I vote for pulling this into the v2010.12 release, beause it is a
bugfix and we get a working code with elf relocation(conceding the
patch is not a perfekt solution, but working)

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2010-12-19  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10  8:01 [U-Boot] [PATCH] arm1136: timer: Replace bss variable by gd Heiko Schocher
2010-12-10  8:09 ` Albert ARIBAUD
2010-12-17 20:13   ` Wolfgang Denk
2010-12-19  8:45     ` Heiko Schocher [this message]
2011-01-20 20:34       ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D0DC62C.6000303@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.