Re: [PATCH v2] ARM: OMAP: Power on EHCI, serial, camera and DVI on beagleboard-xM

[Nishanth Menon <nm@ti.com>]

Koen Kooi wrote, on 12/19/2010 08:42 AM:
$subject - should'nt you be doing this in separate patches? easier to 
track with git bisect at a later date than a whole sale change?

also could you reword it as:
omap3: beagleboard: power on ECHI

and so on?

btw, why are we enabling camera here? should'nt that be done in camera's 
probe function? no?

> Signed-off-by: Koen Kooi<koen@beagleboard.org>
>
> ---
>
> Changes since v1:
> 	* Reenable the PMU stat LED
>
>   arch/arm/mach-omap2/board-omap3beagle.c |   26 ++++++++++++++++++++++++--
>   1 files changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index f1a8ede..4756ac7 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -297,13 +297,35 @@ static int beagle_twl_gpio_setup(struct device *dev,
>   	gpio_request(gpio + 1, "EHCI_nOC");
>   	gpio_direction_input(gpio + 1);
>
> -	/* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, active low) */
> +	/* TWL4030_GPIO_MAX + 0 == ledA, EHCI nEN_USB_PWR (out, XM active
> +	 * high / others active low) */
>   	gpio_request(gpio + TWL4030_GPIO_MAX, "nEN_USB_PWR");
> -	gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
> +	if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM)
> +		gpio_direction_output(gpio + TWL4030_GPIO_MAX, 1);
> +	else
> +		gpio_direction_output(gpio + TWL4030_GPIO_MAX, 0);
> +
> +	/* DVI reset GPIO is different between revisions */
> +	if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM)
> +		beagle_dvi_device.reset_gpio = 129;
> +	else
> +		beagle_dvi_device.reset_gpio = 170;
> +
> +	 /* Power on DVI, Serial and PWR led */
> +	if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
> +		gpio_request(gpio + 1, "nDVI_PWR_EN");
> +		gpio_direction_output(gpio + 1, 0);
> +	}
>
>   	/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */
>   	gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1;
>
> +	/* Power on camera interface on P7/P8 or DVI on A2 and beyond */
> +	if (omap3_beagle_get_rev() == OMAP3BEAGLE_BOARD_XM) {
> +		gpio_request(gpio + 2, "CAM_EN");
> +		gpio_direction_output(gpio + 2, 1);
> +	}
> +
>   	return 0;
>   }
>


-- 
Regards,
Nishanth Menon