From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Avi Kivity <avi@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, aliguori@us.ibm.com, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError
Date: Mon, 20 Dec 2010 14:09:05 +0800 [thread overview]
Message-ID: <4D0EF301.8040903@cn.fujitsu.com> (raw)
In-Reply-To: <4D0B80E2.4070307@redhat.com>
On 12/17/2010 11:25 PM, Avi Kivity wrote:
> On 12/17/2010 01:22 PM, Luiz Capitulino wrote:
>> >
>> > I think Avi's suggest is better, and I will use
>> > "inject-nmi" (without cpu-index argument) to send NMI to all cpus,
>> > like physical GUI. If some one want to send NMI to a set of cpus,
>> > he can use "inject-nmi" multiple times.
>>
>> His suggestion is to drop _all_ arguments, right Avi?
>
> Yes.
>
We don't need to drop the cpu-index argument,
the upstream tools(libvirt etc.) can just issue "inject-nmi"
command without any argument when need.
Reasons to keep this argument
1) Useful for kernel developer or debuger sending NMI to a special CPU.
2) Share the code with nmi of hmp version. Share the way how to
use these two commands.(hmp version and qmp version)
next prev parent reply other threads:[~2010-12-20 6:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 9:49 [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError Lai Jiangshan
2010-12-15 10:49 ` [Qemu-devel] [PATCH v3] qemu, qmp: " Markus Armbruster
2010-12-15 17:14 ` Luiz Capitulino
2010-12-15 17:39 ` Markus Armbruster
2010-12-15 17:52 ` Luiz Capitulino
2010-12-15 17:09 ` [PATCH v3] qemu,qmp: " Luiz Capitulino
2010-12-15 17:18 ` Avi Kivity
2010-12-15 17:26 ` Luiz Capitulino
2010-12-15 17:45 ` Markus Armbruster
2010-12-15 18:00 ` Luiz Capitulino
2010-12-16 9:03 ` Avi Kivity
2010-12-16 10:48 ` Luiz Capitulino
2010-12-16 10:51 ` Avi Kivity
2010-12-16 11:12 ` Luiz Capitulino
2010-12-16 11:47 ` [Qemu-devel] Re: [PATCH v3] qemu, qmp: " Markus Armbruster
2010-12-16 12:50 ` Avi Kivity
2010-12-16 13:09 ` Luiz Capitulino
2010-12-16 13:11 ` Avi Kivity
2010-12-16 13:17 ` Luiz Capitulino
2010-12-17 6:20 ` Lai Jiangshan
2010-12-17 11:22 ` Luiz Capitulino
2010-12-17 15:25 ` Avi Kivity
2010-12-20 6:09 ` Lai Jiangshan [this message]
2011-01-03 13:46 ` Luiz Capitulino
2010-12-16 9:42 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0EF301.8040903@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.