From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] armv7: start.S: code cleanup
Date: Mon, 20 Dec 2010 07:57:21 +0100 [thread overview]
Message-ID: <4D0EFE51.1050308@free.fr> (raw)
In-Reply-To: <1292825699-26688-1-git-send-email-r64343@freescale.com>
Hi Jason,
Le 20/12/2010 07:14, Jason Liu a ?crit :
> Remove the useless code from start.S
>
> Signed-off-by: Jason Liu<r64343@freescale.com>
> ---
> arch/arm/cpu/armv7/start.S | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S
> index 684f2d2..cb4f92f 100644
> --- a/arch/arm/cpu/armv7/start.S
> +++ b/arch/arm/cpu/armv7/start.S
> @@ -171,7 +171,6 @@ stack_setup:
> beq clear_bss /* skip relocation */
> #endif
> mov r1, r6 /* r1<- scratch for copy_loop */
> - ldr r2, _TEXT_BASE
> ldr r3, _bss_start_ofs
> add r2, r0, r3 /* r2<- source end address */
>
> @@ -224,7 +223,6 @@ fixnext:
> clear_bss:
> ldr r0, _bss_start_ofs
> ldr r1, _bss_end_ofs
> - ldr r3, _TEXT_BASE /* Text base */
> mov r4, r6 /* reloc addr */
> add r0, r0, r4
> add r1, r1, r4
These changes are not a bug fix; they will be deferred until after the
upcoming release -- and then, I would welcome a single patchset with
changes to all ARM cpus where this should be done. Can you do this?
Thanks in advance.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-12-20 6:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 6:14 [U-Boot] [PATCH 1/1] armv7: start.S: code cleanup Jason Liu
2010-12-20 6:57 ` Albert ARIBAUD [this message]
2010-12-20 7:05 ` Jason Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0EFE51.1050308@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.