From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suresh Jayaraman Subject: Re: [PATCH 05/18] cifs: move locked sections out of DeleteMidQEntry and AllocMidQEntry Date: Mon, 20 Dec 2010 16:30:17 +0530 Message-ID: <4D0F3741.8030807@suse.de> References: <1292598497-29796-1-git-send-email-jlayton@redhat.com> <1292598497-29796-6-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jeff Layton Return-path: In-Reply-To: <1292598497-29796-6-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 12/17/2010 08:38 PM, Jeff Layton wrote: > In later patches, we're going to need to have finer-grained control > over the addition and removal of these structs from the pending_mid_q > and we'll need to be able to call the destructor while holding the > spinlock. Move the locked sections out of both routines and into > the callers. Fix up current callers of DeleteMidQEntry to call a new > routine that dequeues the entry and then destroys it. > > Signed-off-by: Jeff Layton > --- > fs/cifs/transport.c | 41 ++++++++++++++++++++++++----------------- > 1 files changed, 24 insertions(+), 17 deletions(-) > Looks good to me. Reviewed-by: Suresh Jayaraman