From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suresh Jayaraman Subject: Re: [PATCH 08/18] cifs: don't reconnect server when we don't get a response Date: Mon, 20 Dec 2010 16:57:39 +0530 Message-ID: <4D0F3DAB.9050107@suse.de> References: <1292598497-29796-1-git-send-email-jlayton@redhat.com> <1292598497-29796-9-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jeff Layton Return-path: In-Reply-To: <1292598497-29796-9-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 12/17/2010 08:38 PM, Jeff Layton wrote: > We only want to force a reconnect to the server under very limited and > specific circumstances. Now that we have processes waiting indefinitely > for responses, we shouldn't reach this point unless a reconnect is > already in process. Thus, there's no reason to re-mark the server for > reconnect here. > > Signed-off-by: Jeff Layton > --- > fs/cifs/transport.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c > index c41c9c4..f65cdec 100644 > --- a/fs/cifs/transport.c > +++ b/fs/cifs/transport.c > @@ -374,10 +374,8 @@ sync_mid_result(struct mid_q_entry *mid, struct TCP_Server_Info *server) > if (mid->midState == MID_REQUEST_SUBMITTED) { > if (server->tcpStatus == CifsExiting) > rc = -EHOSTDOWN; > - else { > - server->tcpStatus = CifsNeedReconnect; > + else > mid->midState = MID_RETRY_NEEDED; > - } > } > > if (rc != -EHOSTDOWN) { Looks good to me. Reviewed-by: Suresh Jayaraman