Re: [PATCH] KVM: VMX: Correct asm constraint in vmcs_load()

[Randy Dunlap <randy.dunlap@oracle.com>]

On 12/20/10 01:06, Avi Kivity wrote:
> 'error' is byte sized, so use a byte register constraint.

Hm, OK, but I still get the same build error.


> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>  arch/x86/kvm/vmx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index c195260..a92fdde 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -488,7 +488,7 @@ static void vmcs_load(struct vmcs *vmcs)
>  	u8 error;
>  
>  	asm volatile (__ex(ASM_VMX_VMPTRLD_RAX) "; setna %0"
> -			: "=g"(error) : "a"(&phys_addr), "m"(phys_addr)
> +			: "=qm"(error) : "a"(&phys_addr), "m"(phys_addr)
>  			: "cc", "memory");
>  	if (error)
>  		printk(KERN_ERR "kvm: vmptrld %p/%llx fail\n",


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts:  http://www.xenotime.net/linux/recipes/