Re: [PATCH] TODO: CDMA SMS and CDMA CMAS

[Lei Yu <lei.2.yu@nokia.com>]

[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]

Hi Denis,

On 12/17/2010 03:29 PM, ext Denis Kenzior wrote:
> Hi Lei,
>
> On 12/08/2010 06:34 PM, Lei Yu wrote:
>> ---
>>   TODO |  122 ++++++++++++++++++++++++++++++++++++++++++++++++++---------------
>>   1 files changed, 94 insertions(+), 28 deletions(-)
>>
>
> I get the following when trying to apply this patch:
> fatal: cannot convert from unknown-8bit to UTF-8
>

Yes, I will fix this and re-submit the patch.

> Also, in general we frown upon having major TODO list submissions with
> the Owner field pre-set.  Some of these have slipped through previously,
> but I will be more stringent about enforcing this in the future ;)
>
> The purpose of the Owner field on the TODO is to indicate which tasks
> are being worked on in the immediate present, so that others can pick up
> tasks not being worked on.  So I'd really prefer you to submit this
> patch without the Owner set, and take ownership of the particular task
> as you go along.
>

Yes, I will remove the Owner field when I re-submit the TODO patch.

> Regards,
> -Denis

Regards,
Lei