From: Lei Yu <lei.2.yu@nokia.com>
To: ofono@ofono.org
Subject: Re: [PATCH 3/5] cdma-atmodem: Add CDMA SMS Support
Date: Mon, 20 Dec 2010 13:31:34 -0800 [thread overview]
Message-ID: <4D0FCB36.8040606@nokia.com> (raw)
In-Reply-To: <4D0FBF0A.1080100@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
Hi Denis,
On 12/20/2010 12:39 PM, ext Denis Kenzior wrote:
> On 12/08/2010 06:35 PM, Lei Yu wrote:
>> ---
>> Makefile.am | 7 ++
>> configure.ac | 5 ++
>> drivers/cdma-atmodem/atmodem.c | 47 ++++++++++++
>> drivers/cdma-atmodem/atmodem.h | 23 ++++++
>
> You need to synchronize with Dara on this one. Both of you are sending
> the same stub implementation. I suggest submitting this as a separate
> patch. And please name it cdmamodem/cdmamodem.c& .h. Dara has this
> right actually.
>
I will synchronize with Dara. Most likely, I will hold of submitting
update to my patch at least for 3/5 till Dara's patch is finalized and
accepted.
>> drivers/cdma-atmodem/atutil.c | 45 ++++++++++++
>> drivers/cdma-atmodem/atutil.h | 64 +++++++++++++++++
>
> As I mentioned before, please use the atutil.[ch] from atmodem directly.
> No need to create a new set of these...
>
I will fix this and resubmit after Dara's patch is finalized.
>> drivers/cdma-atmodem/sms.c | 151 ++++++++++++++++++++++++++++++++++++++++
>
> And this one should be in a separate patch ;)
>
Will fix this.
> Regards,
> -Denis
Regards,
Lei
prev parent reply other threads:[~2010-12-20 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 0:35 [PATCH 3/5] cdma-atmodem: Add CDMA SMS Support Lei Yu
2010-12-20 20:39 ` Denis Kenzior
2010-12-20 21:31 ` Lei Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0FCB36.8040606@nokia.com \
--to=lei.2.yu@nokia.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.