From: Dara Spieker-Doyle <dara.spieker-doyle@nokia.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2 3/9] cdma-voicecall: Add CDMA MO Call Support
Date: Mon, 20 Dec 2010 13:47:28 -0800 [thread overview]
Message-ID: <4D0FCEF0.8000501@nokia.com> (raw)
In-Reply-To: <4D0FC19B.6080908@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
Hi Denis
Thank you for reviewing these patches. I will submit new versions for
your comments, please see any open points inline.
On 12/20/2010 12:50 PM, ext Denis Kenzior wrote:
>> + */
>> +
>> +#ifndef __OFONO_CDMA_VOICECALL_H
>> +#define __OFONO_CDMA_VOICECALL_H
>> +
>> +#ifdef __cplusplus
>> +extern "C" {
>> +#endif
>> +
>> +#include<ofono/types.h>
>> +
>> +struct ofono_cdma_voicecall_manager;
>
> Please call this ofono_cdma_voicecall.
This is actually our preference as well as there is no multicall in
CDMA, just the single voicecall. To that end, does it not make sense to
also rename the interface "Voicecall" rather than "VoiceCallManager"?
Cheers
Dara
next prev parent reply other threads:[~2010-12-20 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 23:11 [PATCH v2 3/9] cdma-voicecall: Add CDMA MO Call Support Dara Spieker-Doyle
2010-12-20 20:50 ` Denis Kenzior
2010-12-20 21:47 ` Dara Spieker-Doyle [this message]
2010-12-20 21:48 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0FCEF0.8000501@nokia.com \
--to=dara.spieker-doyle@nokia.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.