From: Larry Finger <Larry.Finger@lwfinger.net>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 7/7] rtlwifi: Use pci_pcie_cap()
Date: Mon, 20 Dec 2010 21:48:32 -0600 [thread overview]
Message-ID: <4D102390.7040300@lwfinger.net> (raw)
In-Reply-To: <1292893316-26694-8-git-send-email-hauke@hauke-m.de>
On 12/20/2010 07:01 PM, Hauke Mehrtens wrote:
> Use function pci_pcie_cap() instead of accessing struct member directly.
>
> CC: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
Is this change really necessary? The inline routine expands exactly to the code
that you replaced. The change just adds one extra layer of obscurity.
If this really is a desirable change, then add
Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Larry
prev parent reply other threads:[~2010-12-21 3:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 1:01 [PATCH 0/7] Small patches from compat-wirelss for mainline Hauke Mehrtens
2010-12-21 1:01 ` [PATCH 1/7] wl1251: remove unnecessary import Hauke Mehrtens
2010-12-21 15:19 ` Kalle Valo
2010-12-21 1:01 ` [PATCH 2/7] wl12xx: " Hauke Mehrtens
2010-12-21 9:32 ` Luciano Coelho
2010-12-21 1:01 ` [PATCH 3/7] ssb: Use pci_is_pcie() Hauke Mehrtens
2010-12-21 1:01 ` [PATCH 4/7] rt2x00: " Hauke Mehrtens
2010-12-21 7:42 ` Gertjan van Wingerde
2010-12-21 11:50 ` Ivo Van Doorn
2010-12-21 1:01 ` [PATCH 5/7] ath5k: " Hauke Mehrtens
2010-12-21 1:01 ` [PATCH 6/7] ath9k: " Hauke Mehrtens
2010-12-21 1:01 ` [PATCH 7/7] rtlwifi: Use pci_pcie_cap() Hauke Mehrtens
2010-12-21 3:48 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D102390.7040300@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.