From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] microblaze: Replace CONFIG_SYS_GBL_DATA_SIZE by auto-generated value (25ddd1fb0a2281b182529afbc8fda5de2dc16d96)
Date: Tue, 21 Dec 2010 09:47:16 +0100 [thread overview]
Message-ID: <4D106994.10307@monstr.eu> (raw)
Hi Wolfgang,
I have just found that your patch (in subject) break gd/bd pointer for
Microblaze. I have done patch which fix it but not sure if is correct.
Microblaze uses small space at the end of ram for gd and bd.
For example:
end of ram 0xd7ff ffff
bd 0xd7ff ffc0
gd 0xd7ff ff80
Your patch uses GENERATED_GBL_DATA_SIZE which is aligned size for
gb_t(0x40) and caused that bd structure (because it is on higher
addresses) is moved out of ram because gd is on 0xd7ff ffc0. Actual size
of bd_t is 0x24 but it is no problem to use 0x40 as aligned size.
The main my point is how should look like position of gd/bd.
Maybe will be worth to take a look at monitor,malloc area and stack.
Microblaze uses:
end of ram
bd 0x40
gd 0x40
monitor area
malloc area
stack (grows down)
Is it OK to use this scheme?
I can easily fix this to previous state but will be good to synchronize
this across archs.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
next reply other threads:[~2010-12-21 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 8:47 Michal Simek [this message]
2010-12-21 10:48 ` [U-Boot] microblaze: Replace CONFIG_SYS_GBL_DATA_SIZE by auto-generated value (25ddd1fb0a2281b182529afbc8fda5de2dc16d96) Wolfgang Denk
2010-12-21 12:25 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D106994.10307@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.