From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 25/29] Check for unlink result
Date: Tue, 21 Dec 2010 16:04:23 +0100 [thread overview]
Message-ID: <4D10C1F7.9090506@redhat.com> (raw)
In-Reply-To: <20101129215111.GO29380@agk-dp.fab.redhat.com>
Dne 29.11.2010 22:51, Alasdair G Kergon napsal(a):
> On Thu, Nov 25, 2010 at 11:55:29AM +0100, Zdenek Kabelac wrote:
>> + if (unlink(path))
>> + log_debug("Unlink %s failed: %s", path, strerror(errno));
>
> log_sys_debug ?
>
At this place it's valid the file in the moment of unlink doesn't exist.
There is no explicit test for existence of backup file - so I've used only
debug to print reason for failure at least in debug log.
(Assuming 'Let this fail silently.' has this meaning)
Zdenek
next prev parent reply other threads:[~2010-12-21 15:04 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 10:55 [PATCH 00/29] Fixes for analyzer problems Zdenek Kabelac
2010-11-25 10:55 ` [PATCH 01/29] Cleanup remove test for NULL Zdenek Kabelac
2010-11-25 17:18 ` Petr Rockai
2010-11-25 10:55 ` [PATCH 02/29] Fix check for empty system_dir Zdenek Kabelac
2010-11-25 17:19 ` Petr Rockai
2010-11-25 23:12 ` Zdenek Kabelac
2010-11-26 7:35 ` Petr Rockai
2010-11-29 23:27 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 03/29] Remove printing of LCK_CACHE Zdenek Kabelac
2010-11-25 17:26 ` Petr Rockai
2010-11-29 20:44 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 04/29] Reset vg pointer after release Zdenek Kabelac
2010-11-25 17:26 ` Petr Rockai
2010-11-25 10:55 ` [PATCH 05/29] Test *buf for NULL Zdenek Kabelac
2010-11-29 20:04 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 06/29] Replace snprintf -> dm_snprintf Zdenek Kabelac
2010-11-29 20:16 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 07/29] Test success from dm_poll_create Zdenek Kabelac
2010-11-29 20:11 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 08/29] Fix memory leak in error path Zdenek Kabelac
2010-11-26 7:37 ` Petr Rockai
2010-11-25 10:55 ` [PATCH 09/29] Remove check for lv is NULL Zdenek Kabelac
2010-11-29 20:09 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 10/29] Add some backtrace - Attention please Zdenek Kabelac
2010-11-29 20:16 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 11/29] Add stack trace for error path Zdenek Kabelac
2010-11-29 20:43 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 12/29] Add test for 'read' result Zdenek Kabelac
2010-11-29 20:19 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 13/29] Put some FIXME warnings in lvmcache_update_vg processing Zdenek Kabelac
2010-12-21 15:15 ` Zdenek Kabelac
2010-11-25 10:55 ` [PATCH 14/29] Remove unneeded check for NULL pvd->system_id Zdenek Kabelac
2010-11-29 20:21 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 15/29] Modify test to catch passing NULL pointer Zdenek Kabelac
2010-11-29 21:17 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 16/29] Test uuid for NULL Zdenek Kabelac
2010-11-29 21:00 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 17/29] Optimize second call to strchr with same parameters Zdenek Kabelac
2010-11-29 20:50 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 18/29] Check result of vginfo_from_vgname Zdenek Kabelac
2010-11-29 20:56 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 19/29] Test for error status Zdenek Kabelac
2010-11-29 21:02 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 20/29] Add test for lv_name not NULL Zdenek Kabelac
2010-11-29 21:21 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 21/29] Instrument with nonnull dev_manager_transient Zdenek Kabelac
2010-11-29 21:51 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 22/29] Ensure pointer first is notnull before dereference Zdenek Kabelac
2010-11-29 21:56 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 23/29] Add test and error message for failure case Zdenek Kabelac
2010-11-29 21:18 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 24/29] Test for str_list_add Zdenek Kabelac
2010-11-29 21:19 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 25/29] Check for unlink result Zdenek Kabelac
2010-11-29 21:50 ` Alasdair G Kergon
2010-11-29 21:51 ` Alasdair G Kergon
2010-12-21 15:04 ` Zdenek Kabelac [this message]
2010-11-25 10:55 ` [PATCH 26/29] Add stack traces for dev_set/close_immediate error path Zdenek Kabelac
2010-11-29 21:22 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 27/29] Add standard check for result of lv_info call Zdenek Kabelac
2010-11-25 16:24 ` Zdenek Kabelac
2010-11-29 21:34 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 28/29] Check type is not NULL before access Zdenek Kabelac
2010-11-29 21:38 ` Alasdair G Kergon
2010-11-25 10:55 ` [PATCH 29/29] Check for NULL pointer Zdenek Kabelac
2010-11-25 23:02 ` Zdenek Kabelac
2010-11-29 22:47 ` Alasdair G Kergon
2010-11-30 12:33 ` Zdenek Kabelac
2010-11-30 13:07 ` Alasdair G Kergon
2010-11-29 21:43 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D10C1F7.9090506@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.