From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/3] libipulog: rebuild required header file inclusion
Date: Tue, 21 Dec 2010 20:46:32 +0100 [thread overview]
Message-ID: <4D110418.4020506@netfilter.org> (raw)
In-Reply-To: <1292703453-16324-2-git-send-email-jengelh@medozas.de>
On 18/12/10 21:17, Jan Engelhardt wrote:
> Use C++ headers for C++ and throw out #includes that are not needed
> for the header file.
>
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
> ---
> include/libnetfilter_log/libipulog.h | 9 ++++++---
> src/libipulog_compat.c | 1 +
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/include/libnetfilter_log/libipulog.h b/include/libnetfilter_log/libipulog.h
> index 0278862..bb6736a 100644
> --- a/include/libnetfilter_log/libipulog.h
> +++ b/include/libnetfilter_log/libipulog.h
> @@ -1,9 +1,12 @@
> #ifndef _LIBIPULOG_H
> #define _LIBIPULOG_H
>
> -#include <errno.h>
> -#include <unistd.h>
> -#include <fcntl.h>
> +#ifdef __cplusplus
> +# include <cstdint>
> +#else
> +# include <stdint.h>
> +#endif
> +#include <sys/types.h>
I agree that these headers shouldn't be there but I'm worry about
breaking the compilation of existing applications that, for whatever
reason, rely on these includes.
next prev parent reply other threads:[~2010-12-21 19:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 20:17 libnetfilter_log: misc annotations Jan Engelhardt
2010-12-18 20:17 ` [PATCH 1/3] libipulog: rebuild required header file inclusion Jan Engelhardt
2010-12-21 19:46 ` Pablo Neira Ayuso [this message]
2010-12-18 20:17 ` [PATCH 2/3] src: remove redundant casts Jan Engelhardt
2010-12-21 19:56 ` Pablo Neira Ayuso
2010-12-18 20:17 ` [PATCH 3/3] src: declare non-modified data as const Jan Engelhardt
2010-12-21 19:56 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D110418.4020506@netfilter.org \
--to=pablo@netfilter.org \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.