From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
John Kacur <jkacur@redhat.com>,
James Bottomley <James.Bottomley@suse.de>,
Ingo Molnar <mingo@elte.hu>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Thomas Gleixner <tglx@linutronix.de>,
Namhyung Kim <namhyung@gmail.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 2/4] futex,plist: remove debug lock assignment for plist_node
Date: Wed, 22 Dec 2010 13:57:39 +0800 [thread overview]
Message-ID: <4D119353.9030401@cn.fujitsu.com> (raw)
In-Reply-To: <4D10FC90.6020104@linux.intel.com>
On 12/22/2010 03:14 AM, Darren Hart wrote:
> On 12/21/2010 01:55 AM, Lai Jiangshan wrote:
>> original code use&plist_node->plist as the faked head of
>> the priority list for plist_del(), these debug locks in
>> the faked head are needed for CONFIG_DEBUG_PI_LIST.
>>
>> But now we always pass the real head to plist_del(), the debug locks
>> in plist_node will not be used, so we remove these assignments.
>
> Any reason to keep this separate from patch 1/4 ?
>
Make the changes clearer and the patches are easier to read.
For me the purposes of patch 1/4 and 2/4 are different,
1/4 makes the code sensible. 2/4 removes unused code.
next prev parent reply other threads:[~2010-12-22 5:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 9:55 [PATCH 2/4] futex,plist: remove debug lock assignment for plist_node Lai Jiangshan
2010-12-21 19:14 ` Darren Hart
2010-12-22 5:57 ` Lai Jiangshan [this message]
2010-12-22 6:47 ` Darren Hart
2010-12-22 16:24 ` Darren Hart
2011-03-12 10:58 ` [tip:core/futexes] futex,plist: Remove debug lock assignment from plist_node tip-bot for Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D119353.9030401@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=James.Bottomley@suse.de \
--cc=dvhart@linux.intel.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.