From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style
Date: Wed, 22 Dec 2010 14:38:12 +0300 [thread overview]
Message-ID: <4D11E324.7060403@mvista.com> (raw)
In-Reply-To: <1292955178-13018-1-git-send-email-monstr@monstr.eu>
Hello.
On 21-12-2010 21:12, Michal Simek wrote:
> Clear coding style issues.
> Signed-off-by: Michal Simek<monstr@monstr.eu>
[...]
> diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c
> index 2209561..f1af7e2 100644
> --- a/lib/asm-offsets.c
> +++ b/lib/asm-offsets.c
> @@ -19,11 +19,11 @@
>
> #include<linux/kbuild.h>
>
> -int main(void)
> +int main (void)
Why add space before paren? checkpatch.pl wouldn't like it.
> {
> /* Round up to make sure size gives nice stack alignment */
> - DEFINE(GENERATED_GBL_DATA_SIZE,
> - (sizeof(struct global_data)+15) & ~15);
> + DEFINE (GENERATED_GBL_DATA_SIZE,
Same here...
WBR, Sergei
prev parent reply other threads:[~2010-12-22 11:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 18:12 [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style Michal Simek
2010-12-21 18:12 ` [U-Boot] [PATCH 2/3] Autogenerate GENERATED_BD_INFO_SIZE Michal Simek
2010-12-21 18:12 ` [U-Boot] [PATCH 3/3] microblaze: Fix bdiinfo pointer Michal Simek
2010-12-21 19:01 ` Wolfgang Denk
2010-12-21 20:45 ` Michal Simek
2010-12-21 21:15 ` Wolfgang Denk
2010-12-21 18:56 ` [U-Boot] [PATCH 2/3] Autogenerate GENERATED_BD_INFO_SIZE Wolfgang Denk
2010-12-21 18:55 ` [U-Boot] [PATCH 1/3] lib/asm-offsets.c: Clean coding style Wolfgang Denk
2010-12-21 20:02 ` Michal Simek
2010-12-21 21:11 ` Wolfgang Denk
2010-12-22 6:39 ` Michal Simek
2010-12-22 7:00 ` Wolfgang Denk
2010-12-22 7:19 ` Michal Simek
2010-12-22 11:38 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D11E324.7060403@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.