From: Saul Wold <sgw@linux.intel.com>
To: Lu Jingdong <jingdong.lu@windriver.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/3] Fix failures of LSB.
Date: Wed, 22 Dec 2010 07:21:12 -0800 [thread overview]
Message-ID: <4D121768.5080108@linux.intel.com> (raw)
In-Reply-To: <4D11CAA8.1020106@windriver.com>
On 12/22/2010 01:53 AM, Lu Jingdong wrote:
> On 12/22/2010 08:41 AM, Saul Wold wrote:
>> On 12/21/2010 01:54 AM, Jingdong Lu wrote:
>>> Pull URL: git://git.pokylinux.org/poky-contrib.git
>>> Branch: jingdonglu/distro
>>> Browse:
>>> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/distro
>>>
>>> Thanks,
>>> Jingdong Lu<jingdong.lu@windriver.com>
>>> ---
>>>
>>
>> Jingdong,
>>
>>
>>
>> Why do you need the do_install? Can the standard do_install not work
>> correctly for this recipe?
> Because we need add some options to make install, eg,
> UCBINSTALL=install, I didn't use standard do_install.
>
>> meta/recipes-extended/mailx/mailx_12.4.bb | 18 ++++++++++++++++++
>> Can you please add a SUMMARY and SRC_URI checksums to the mailx recipe.
>>
Jingdong,
You added SRC_URI Checksums, but not the SUMMARY, also see Richard's
comments about using ${prefix}, please re-submit a v3 of this patch.
Sau!
>> Is the PREFIX=/usr correct? I note in other there is a ${D} or
>> ${D}${prefix}, please make sure you have the correct location here.
> Because the default value of PREFIX is /usr/local in Makefile, I change
> it into /usr and give this option.
>>
>> Please re-sumbit a v2 patch set.
> I re-submit patch set.
> Thank you!
>>
>>
>
>
prev parent reply other threads:[~2010-12-22 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 9:54 [PATCH 0/3] Fix failures of LSB Jingdong Lu
2010-12-21 9:54 ` [PATCH 1/3] perl: Add GDBM_File into perl extension Jingdong Lu
2010-12-21 9:54 ` [PATCH 2/3] gcc: Add "--enable-clocale=gnu" option explicitly Jingdong Lu
2010-12-21 9:54 ` [PATCH 3/3] mailx: Add mailx Jingdong Lu
2010-12-22 0:41 ` [PATCH 0/3] Fix failures of LSB Saul Wold
2010-12-22 9:53 ` Lu Jingdong
2010-12-22 11:11 ` Richard Purdie
2010-12-22 15:21 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D121768.5080108@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=jingdong.lu@windriver.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.