Re: [PATCH 0/3]distrodata.bbcalss: To get more precise upstream version for pkg report system

[Saul Wold <saul.wold@intel.com>]

On 12/22/2010 05:22 AM, Mei Lei wrote:
> There are some changes to get more recipes upstream version and to generate some necessary data for pkg report system.
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: lmei3/pkg-report-system
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/pkg-report-system
>
> Thanks,
>      Mei Lei<lei.mei@intel.com>
> ---
>
Lei:

There are various issues with these patches please see my comments below

>
> Mei Lei (3):
>    distrodata.bbclass: Change for package report system
Not sure why you needed to add a logpath2 as you are using the same 
LOG_DIR var as logpath. Are you intending to create a separate directory.

Is there a reason you need to have each package into in separate files? 
Can your tool not read 1 larger flat file then we can just use 1 output 
format for the spreadsheet

>    base.bbclass: Add inherit information for checkpkg task
We don't want to inherit the distrodata  by default, you can add this to 
your local.conf

>    bitbake.conf: Change the GNU_MIRROR to get more precise result
>
Not sure how this gives a more precise result, gnu and pub/gnu are the 
same location, one is linked to the other.

Sau!

>   meta/classes/base.bbclass       |    4 +-
>   meta/classes/distrodata.bbclass |   44 +++++++++++++++++++++++++++++++-------
>   meta/conf/bitbake.conf          |    2 +-
>   3 files changed, 39 insertions(+), 11 deletions(-)
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>