From: Joel Soete <soete.joel@scarlet.be>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: Help: major pppoe regression since 2.6.35 (panic on first ppp conection)?
Date: Thu, 23 Dec 2010 11:02:55 +0000 [thread overview]
Message-ID: <4D132C5F.8090404@scarlet.be> (raw)
In-Reply-To: <1293035100.3027.247.camel@edumazet-laptop>
Hello Eric,
On 12/22/2010 04:25 PM, Eric Dumazet wrote:
[snip]
>
> Something overwrites nr_frags in skb_shinfo(skb)
>
> As skb_shinfo follows head portion of an skb, something overflows skb
> head
>
> Please try adding some room like in following patch ?
>
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index e6ba898..adf2834 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -187,6 +187,7 @@ enum {
> * the end of the header data, ie. at skb->end.
> */
> struct skb_shared_info {
> + char filler[64];
> unsigned short nr_frags;
> unsigned short gso_size;
> /* Warning: this field is not always filled in (UFO)! */
>
Sorry for delay but I have good news, I am sending this answer from:
$ uname -a
Linux sidh2 2.6.37-rc7-amd64-t1 #1 SMP Thu Dec 23 10:30:27 GMT 2010 x86_64 GNU/Linux
with your tips ;<) (without kernel had already died)
That said how can find stuff overflowing skb head? (all I say, is that this issue started with 2.6.34-git6???)
Thanks a lot,
J.
next prev parent reply other threads:[~2010-12-23 11:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 11:33 Help: major pppoe regression since 2.6.35 (panic on first ppp conection)? Joel Soete
2010-12-20 11:03 ` Joel Soete
2010-12-22 8:22 ` Andrew Morton
2010-12-22 11:00 ` Jarek Poplawski
2010-12-22 16:00 ` Joel Soete
2010-12-22 16:25 ` Eric Dumazet
2010-12-23 11:02 ` Joel Soete [this message]
2010-12-23 12:12 ` Eric Dumazet
2010-12-23 20:25 ` Jarek Poplawski
[not found] ` <4D148271.8030509@scarlet.be>
2010-12-24 15:13 ` Jarek Poplawski
2010-12-25 12:10 ` Jarek Poplawski
2010-12-25 13:51 ` Joel Soete
2010-12-25 15:12 ` [PATCH net-2.6] sundance: Fix oopses with corrupted skb_shared_info Jarek Poplawski
2010-12-25 17:31 ` [PATCH net-2.6] epic100: hamachi: yellowfin: Fix skb allocation size Jarek Poplawski
2010-12-25 17:39 ` [PATCH net-2.6 v2] " Jarek Poplawski
2010-12-26 3:42 ` David Miller
2010-12-26 3:42 ` [PATCH net-2.6] sundance: Fix oopses with corrupted skb_shared_info David Miller
2010-12-26 11:01 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D132C5F.8090404@scarlet.be \
--to=soete.joel@scarlet.be \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.