From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suresh Jayaraman Subject: Re: [PATCH 17/18] cifs: mangle existing header for SMB_COM_NT_CANCEL Date: Thu, 23 Dec 2010 16:35:32 +0530 Message-ID: <4D132CFC.8000704@suse.de> References: <1292598497-29796-1-git-send-email-jlayton@redhat.com> <1292598497-29796-18-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jeff Layton Return-path: In-Reply-To: <1292598497-29796-18-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 12/17/2010 08:38 PM, Jeff Layton wrote: > The NT_CANCEL command looks just like the original command, except for a > few small differences. The send_nt_cancel function however currently takes > a tcon, which we don't have in SendReceive and SendReceive2. > > Instead of "respinning" the entire header for an NT_CANCEL, just mangle > the existing header by replacing just the fields we need. This means we > don't need a tcon and allows us to call it from other places. > > Signed-off-by: Jeff Layton > --- > fs/cifs/transport.c | 63 ++++++++++++++++++++++++++++++-------------------- > 1 files changed, 38 insertions(+), 25 deletions(-) > Looks good to me. Reviewed-by: Suresh Jayaraman