Re: [PATCH #upstream-fixes] libata: no special completion processing for EH commands

[Jeff Garzik <jeff@garzik.org>]

On 12/09/2010 09:59 AM, Tejun Heo wrote:
> ata_qc_complete() contains special handling for certain commands.  For
> example, it schedules EH for device revalidation after certain
> configurations are changed.  These shouldn't be applied to EH
> commands but they were.
>
> In most cases, it doesn't cause an actual problem because EH doesn't
> issue any command which would trigger special handling; however, ACPI
> can issue such commands via _GTF which can cause weird interactions.
>
> Restructure ata_qc_complete() such that EH commands are always passed
> on to __ata_qc_complete().
>
> stable: Please apply to -stable only after 2.6.38 is released.
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Reported-by: Kyle McMartin<kyle@mcmartin.ca>
> Cc: stable@kernel.org
> ---
>   drivers/ata/libata-core.c |   24 +++++++++++++++---------
>   1 file changed, 15 insertions(+), 9 deletions(-)

applied