All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Theodore Kilgore <kilgota@banach.math.auburn.edu>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Adds the Lego Bionicle to existing sq905c
Date: Sat, 25 Dec 2010 10:36:20 +0100	[thread overview]
Message-ID: <4D15BB14.3010601@redhat.com> (raw)
In-Reply-To: <4D15B75C.80405@redhat.com>

Hi,

On 12/25/2010 10:20 AM, Mauro Carvalho Chehab wrote:
> Em 24-12-2010 17:55, Hans de Goede escreveu:
>> Mauro,
>>
>> Will you pick up this patch directly or should I put it in my tree ?
>
> Either way works for me (but I prefer if one of the gspca maintainers/sub-mainainers
> pick). If you don't pick it, please reply with your ack.

Given that nothing else is going into my tree at the moment I would
prefer for you to pick it up directly, so:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Thanks & Regards,

Hans


>>
>> Regards,
>>
>> Hans
>>
>>
>> On 12/24/2010 09:06 PM, Theodore Kilgore wrote:
>>> This patch adds the Vendor:Product number of the Lego Bionicle camera to
>>> the existing gspca/sq905c.c and also a line for the camera in gspca.txt.
>>> The camera works "out of the box" with these small changes. So this is
>>> just in time for Christmas. Think of the children.
>>>
>>> Signed-off-by: Theodore Kilgore<kilgota@auburn.edu>
>>>
>>> ---------------------------------------------
>>> diff --git a/Documentation/video4linux/gspca.txt b/Documentation/video4linux/gspca.txt
>>> index 6a562ee..261776e 100644
>>> --- a/Documentation/video4linux/gspca.txt
>>> +++ b/Documentation/video4linux/gspca.txt
>>> @@ -366,6 +366,7 @@ t613        17a1:0128    TASCORP JPEG Webcam, NGS Cyclops
>>>    vc032x        17ef:4802    Lenovo Vc0323+MI1310_SOC
>>>    pac207        2001:f115    D-Link DSB-C120
>>>    sq905c        2770:9050    Disney pix micro (CIF)
>>> +sq905c        2770:9051    Lego Bionicle
>>>    sq905c        2770:9052    Disney pix micro 2 (VGA)
>>>    sq905c        2770:905c    All 11 known cameras with this ID
>>>    sq905        2770:9120    All 24 known cameras with this ID
>>> diff --git a/drivers/media/video/gspca/sq905c.c b/drivers/media/video/gspca/sq905c.c
>>> index c2e88b5..8ba1995 100644
>>> --- a/drivers/media/video/gspca/sq905c.c
>>> +++ b/drivers/media/video/gspca/sq905c.c
>>> @@ -301,6 +301,7 @@ static int sd_start(struct gspca_dev *gspca_dev)
>>>    static const __devinitdata struct usb_device_id device_table[] = {
>>>        {USB_DEVICE(0x2770, 0x905c)},
>>>        {USB_DEVICE(0x2770, 0x9050)},
>>> +    {USB_DEVICE(0x2770, 0x9051)},
>>>        {USB_DEVICE(0x2770, 0x9052)},
>>>        {USB_DEVICE(0x2770, 0x913d)},
>>>        {}
>>>
>

  reply	other threads:[~2010-12-25  9:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22 11:30 nasty bug at qv4l2 Mauro Carvalho Chehab
2010-12-24 14:19 ` Hans de Goede
2010-12-24 14:20   ` Hans Verkuil
2010-12-24 14:41     ` Hans de Goede
2010-12-24 18:54       ` Hans Verkuil
2010-12-25  9:14         ` Mauro Carvalho Chehab
2010-12-25 14:09           ` Mauro Carvalho Chehab
2010-12-28 22:53             ` Hans de Goede
2010-12-29 18:40               ` Hans Verkuil
2010-12-25  8:54       ` Mauro Carvalho Chehab
2010-12-31 15:02     ` Hans de Goede
2010-12-31 15:08       ` Hans Verkuil
2010-12-31 16:18         ` Mauro Carvalho Chehab
2010-12-24 20:06   ` [PATCH] Adds the Lego Bionicle to existing sq905c Theodore Kilgore
2010-12-24 19:55     ` Hans de Goede
2010-12-25  9:20       ` Mauro Carvalho Chehab
2010-12-25  9:36         ` Hans de Goede [this message]
2010-12-25  9:52           ` Jean-Francois Moine
2010-12-25 10:24             ` Mauro Carvalho Chehab
2010-12-25 18:14             ` Theodore Kilgore
2010-12-25 18:44               ` Jean-Francois Moine
2010-12-25 17:59           ` Theodore Kilgore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D15BB14.3010601@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=kilgota@banach.math.auburn.edu \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.