From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PWY1U-0003JQ-Qp for mharc-grub-devel@gnu.org; Sat, 25 Dec 2010 12:35:16 -0500 Received: from [140.186.70.92] (port=43717 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PWY1S-0003JB-CZ for grub-devel@gnu.org; Sat, 25 Dec 2010 12:35:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PWY1Q-0001ix-RN for grub-devel@gnu.org; Sat, 25 Dec 2010 12:35:14 -0500 Received: from mail-wy0-f169.google.com ([74.125.82.169]:32874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PWY1Q-0001iZ-N5 for grub-devel@gnu.org; Sat, 25 Dec 2010 12:35:12 -0500 Received: by wyj26 with SMTP id 26so7876535wyj.0 for ; Sat, 25 Dec 2010 09:35:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=mhWNMofyomhY+pvTDqozFHm4oTAZaIXnmGwApdBNrcg=; b=W+3OTMonS3NHSZqQ5EqXt7z8QMTVzfoRxdmkLcBZEWHpWSCpluTROFvB0vTadk/XXF SAIRkD2/INt9Zw/1x2BbBtUUHbi4ElTIhRN8Rzy9JqU6vfKioCiqwbNHd7bi9jfJHoQb Zkx/dSgo+zbUvV6HxjqJG4WcAZg1l394AHyj8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=uo56vdnDGNt+ZS6VmFcFFTEmyiolwWPKnHlsvMljQ8XRouP4/Jn0sJQ8U3sJY2jqpJ 403NSiQUo2lXllSLB6lNIEhVmYyjgWkYFF1SOGqY2nw5gRcUjEEFEKSchBPquGgz6FU4 1T6HjOyOle6znG8xNB0ohA1m2mU7UeP3KWSUA= Received: by 10.216.181.199 with SMTP id l49mr14082498wem.68.1293298510124; Sat, 25 Dec 2010 09:35:10 -0800 (PST) Received: from debian.bg45.phnet (12-131.62-81.cust.bluewin.ch [81.62.131.12]) by mx.google.com with ESMTPS id x3sm4950633wes.46.2010.12.25.09.35.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 25 Dec 2010 09:35:08 -0800 (PST) Message-ID: <4D162B42.8080806@gmail.com> Date: Sat, 25 Dec 2010 18:34:58 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101211 Icedove/3.0.11 MIME-Version: 1.0 To: grub-devel@gnu.org References: <201012170519.oBH5JVMn034148@m5p.com> In-Reply-To: <201012170519.oBH5JVMn034148@m5p.com> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig7479627F077379CC440CCFEC" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Two Small Patches (x86 VolId & Sun Label Checking) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Dec 2010 17:35:15 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7479627F077379CC440CCFEC Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/17/2010 06:19 AM, ehem+grub@m5p.com wrote: > I've got a system with an oddball, but valid setup that is outside the > bounds of what GRUB supports. As such I'm starting to work on > familiarizing myself with GRUB2's internals on the way to solving the > problem. > > I've found two issues worth fixing so far and I'm attaching patches. > First, what is refered to as "a magic number used by Windows NT" is > apparently used as a volume identifier to identify disks.=20 It's windows NT Volume ID. I don't see how it is a misnomer. > Current > versions of LILO in fact use it to locate the disk holding its second > stage. Second, perhaps minor, but I'm surprised someone chose to break > the checksum verification code in grub-core/partmap/sun.c and didn't > didn't keep the magic number check with it. This seems to be just moving the code around. There are many different coding styles. Changing from one of them to another is waste of effort unless it's done to uniformise with rest of codebase. I don't have strong preference to one or another style so I prefer not to touch anythi= ng. > I hereby release the two > attached patches under GPL version 3 and subsequent varients. > > =20 > I'm not very familiar with Bazaar, shouldn't be a problem. Does seem gi= t > is taking over from Subversion. > > > =20 > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig7479627F077379CC440CCFEC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk0WK0oACgkQNak7dOguQgm2WgEAo948EUPeD0JjfKLJ4FRb5V3S 2Q5sJw2sUZt9gGk27kQBAIvQc7MCPypA0MblCslB1wax0swT60llGNNtm0GwkcW3 =1F3c -----END PGP SIGNATURE----- --------------enig7479627F077379CC440CCFEC--