From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Correct chip detect logic
Date: Mon, 27 Dec 2010 14:29:55 +0300 [thread overview]
Message-ID: <4D1878B3.3090707@mvista.com> (raw)
In-Reply-To: <AANLkTi=_PD4hq16-zXZ7p+wZ8MnxuKucBxa2eitjC1W-@mail.gmail.com>
Hello.
On 26-12-2010 5:41, Yanjun Yang wrote:
> The lan91c96_detect_chip routine is not correct according
> to the manual.
> Signed-off-by: YanJun Yang<yangyj.ee@gmail.com>
[...]
> diff --git a/drivers/net/lan91c96.c b/drivers/net/lan91c96.c
> index bd6966e..2550aa2 100644
> --- a/drivers/net/lan91c96.c
> +++ b/drivers/net/lan91c96.c
> @@ -780,7 +780,7 @@ static int lan91c96_detect_chip(struct eth_device *dev)
> u8 chip_id;
> int r;
> SMC_SELECT_BANK(dev, 3);
> - chip_id = SMC_inw(dev, 0xA)& LAN91C96_REV_REVID;
> + chip_id = (SMC_inw(dev, 0xA)& LAN91C96_REV_CHIPID)>>
Indent with tabs, not spaces.
> LAN91C96_CHIPID_SHIFT;
Your patch is line-wrapped.
> SMC_SELECT_BANK(dev, 0);
> for (r = 0; r< sizeof(supported_chips) / sizeof(struct id_type); r++)
> if (chip_id == supported_chips[r].id)
> diff --git a/drivers/net/lan91c96.h b/drivers/net/lan91c96.h
> index 6fbb0e3..609c92b 100644
> --- a/drivers/net/lan91c96.h
> +++ b/drivers/net/lan91c96.h
> @@ -519,7 +519,8 @@ typedef unsigned long int dword;
> ****************************************************************************
> */
> #define LAN91C96_REV_REVID (0xFU<< 0)
> -#define LAN91C96_REV_CHIPID (0xFU<< 4)
> +#define LAN91C96_CHIPID_SHIFT 4
> +#define LAN91C96_REV_CHIPID (0xFU<< LAN91C96_CHIPID_SHIFT)
Align the macro values please.
WBR, Sergei
prev parent reply other threads:[~2010-12-27 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-26 2:41 [U-Boot] [PATCH] Correct chip detect logic Yanjun Yang
2010-12-27 11:29 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1878B3.3090707@mvista.com \
--to=sshtylyov@mvista.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.