All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bian Naimeng <biannm@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH]fix bug of tst_brk
Date: Tue, 28 Dec 2010 14:42:38 +0800	[thread overview]
Message-ID: <4D1986DE.50309@cn.fujitsu.com> (raw)

Test will fail if invoke tst_brk with (TCONF | TERRNO), it's not our expectation.

Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>

---
 lib/tst_res.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/tst_res.c b/lib/tst_res.c
index 2debd44..193653f 100644
--- a/lib/tst_res.c
+++ b/lib/tst_res.c
@@ -616,21 +616,21 @@ void tst_brk(int ttype, char *fname, void (*func)(void), char *arg_fmt, ...)
 		sprintf(Warn_mesg, "tst_brk(): Invalid Type: %d.  Using TBROK",
 			ttype_result);
 		tst_print(TCID, 0, TWARN, Warn_mesg);
-		ttype = TBROK;
+		ttype = (ttype & ~ttype_result) | TBROK;
 	}
 
 	/* Print the first result, if necessary. */
 	if (Tst_count < TST_TOTAL)
 		tst_res(ttype, fname, "%s", tmesg);
 
-	if (ttype == TCONF) {
+	if (ttype_result == TCONF) {
 		tst_res(ttype, NULL,
 			"Remaining cases not appropriate for configuration");
 	} else {
-		if (ttype == TRETR)
+		if (ttype_result == TRETR)
 			tst_res(ttype, NULL, "Remaining cases retired");
 		else
-			tst_res(TBROK, NULL, "Remaining cases broken");
+			tst_res(ttype, NULL, "Remaining cases broken");
 	}
 	Expand_varargs = TRUE;
 
-- 
1.7.0.4




-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

             reply	other threads:[~2010-12-28  6:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-28  6:42 Bian Naimeng [this message]
2011-01-02  1:11 ` [LTP] [PATCH]fix bug of tst_brk Garrett Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D1986DE.50309@cn.fujitsu.com \
    --to=biannm@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=yanegomi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.