From: Marco Stornelli <marco.stornelli@gmail.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
tytso@mit.edu, chris.mason@oracle.com
Subject: Re: Bug in ext4/btrfs fallocate?
Date: Wed, 29 Dec 2010 10:02:27 +0100 [thread overview]
Message-ID: <4D1AF923.1090502@gmail.com> (raw)
In-Reply-To: <6A86E6B8-E14E-484B-BBF5-F3C580337661@dilger.ca>
Il 29/12/2010 07:46, Andreas Dilger ha scritto:
> On 2010-12-28, at 09:06, Marco Stornelli wrote:
>> it seems that ext4/btrfs code for fallocate doesn't check for
>> immutable/append inode flag.
>
> fallocate() probably shouldn't be allowed for immutable files, but it makes a lot of sense to call fallocate() on append-only files to avoid fragmentation, though it should only be called with the KEEP_SIZE flag.
>
> Cheers, Andreas
>
It seems that only ocfs2 does that check, however I think not checking
for immutable flag is an error, for the append case maybe you're right,
doing this operation on append-only files has got sense.
Marco
prev parent reply other threads:[~2010-12-29 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-28 16:06 Bug in ext4/btrfs fallocate? Marco Stornelli
2010-12-29 6:46 ` Andreas Dilger
2010-12-29 9:02 ` Marco Stornelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1AF923.1090502@gmail.com \
--to=marco.stornelli@gmail.com \
--cc=adilger@dilger.ca \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.