All of lore.kernel.org
 help / color / mirror / Atom feed
From: mike@compulab.co.il (Mike Rapoport)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm/pxa: fix build of it8152
Date: Thu, 30 Dec 2010 09:56:41 +0200	[thread overview]
Message-ID: <4D1C3B39.5070208@compulab.co.il> (raw)
In-Reply-To: <1293654828-24661-1-git-send-email-bigeasy@linutronix.de>

On 12/29/10 22:33, Sebastian Andrzej Siewior wrote:
> Probably since 6ac6b817 aka ("ARM: pxa: encode IRQ number into
> .nr_irqs") the build fails with:
> |   CC      arch/arm/common/it8152.o
> | arch/arm/common/it8152.c: In function ?it8152_init_irq?:
> | arch/arm/common/it8152.c:86: error: ?IT8152_LAST_IRQ? undeclared (first use in this function)
> | arch/arm/common/it8152.c:86: error: (Each undeclared identifier is reported only once
> | arch/arm/common/it8152.c:86: error: for each function it appears in.)
> 
> Before that commit IT8152_LAST_IRQ was (IRQ_BOARD_END + 40) with the
> first IRQ beeing IRQ_BOARD_START. This change als adds +40 so I hope
> this works (I have no HW to verify).
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

I've already sent a patch for this (1), hopefully Eric or Russell will pick it up.

[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-December/036570.html
> ---
>  arch/arm/include/asm/hardware/it8152.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/include/asm/hardware/it8152.h b/arch/arm/include/asm/hardware/it8152.h
> index 21fa272..e3931a9 100644
> --- a/arch/arm/include/asm/hardware/it8152.h
> +++ b/arch/arm/include/asm/hardware/it8152.h
> @@ -81,6 +81,8 @@ extern unsigned long it8152_base_address;
>  #define IT8152_LD_IRQ_COUNT     9
>  #define IT8152_LP_IRQ_COUNT     16
>  #define IT8152_PD_IRQ_COUNT     15
> +#define IT8152_LAST_IRQ		(IT8152_IRQ(0) + IT8152_LD_IRQ_COUNT + \
> +				IT8152_LP_IRQ_COUNT + IT8152_PD_IRQ_COUNT)
>  
>  /* Priorities: */
>  #define IT8152_PD_IRQ(i)        IT8152_IRQ(i)


-- 
Sincerely yours,
Mike.

      parent reply	other threads:[~2010-12-30  7:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-29 20:33 [PATCH 1/2] arm/pxa: fix build of it8152 Sebastian Andrzej Siewior
2010-12-29 20:33 ` [PATCH 2/2] arm/pxa: buildfix for pam27x without fb Sebastian Andrzej Siewior
2011-01-03 15:57   ` Eric Miao
2011-01-03 22:07     ` Marek Vasut
2011-01-04  4:00       ` Eric Miao
2010-12-30  7:56 ` Mike Rapoport [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D1C3B39.5070208@compulab.co.il \
    --to=mike@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.