Re: [PATCH] gnome-power-manager: fix compilation

["Eric Bénard" <eric@eukrea.com>]

Hi Paul,

On 30/12/2010 11:20, Paul Menzel wrote:
> Am Donnerstag, den 30.12.2010, 09:55 +0100 schrieb Eric Bénard:
>
> I would prefer if the error message `libtool: Command not found` (if it
> is that short) is noted in the commit summary.
>
> 	gnome-power-manager: fix compilation: `libtool: Command not found`
>
OK fixed and pushed.

>> * libtool is hardcoded in src/Makefile and leads to
>> libtool: Command not found
>>
>> Signed-off-by: Eric Bénard<eric@eukrea.com>
>> ---
>>   recipes/gnome/gnome-power-manager_2.30.0.bb |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/recipes/gnome/gnome-power-manager_2.30.0.bb b/recipes/gnome/gnome-power-manager_2.30.0.bb
>> index a752852..0c7bcb5 100644
>> --- a/recipes/gnome/gnome-power-manager_2.30.0.bb
>> +++ b/recipes/gnome/gnome-power-manager_2.30.0.bb
>> @@ -27,6 +27,7 @@ do_configure_append() {
>>           for i in $(find ${S} -name "Makefile") ; do
>>               sed -i -e s:-Werror::g $i
>>           done
>> +		sed -e "s/libtool --/${TARGET_SYS}-libtool --/" -i ${S}/src/Makefile
>>   }
>>
>>   PACKAGES =+ "${PN}-applets"
>
> Acked-by: Paul Menzel<paulepanter@users.sourceforge.net>
>
> What is the proper patch to send upstream? Is `${TARGET_SYS}` always
> defined? But »-« would still make problems, wouldn’t it? Is there a
> program implementing this correctly in `Makefile`?
>
- TARGET_SYS is OE specific.
- The "--" is here to only replace the 2 or 3 instances of libtool concerned 
by the workaround.
- I don't know what would be the proper patch to send upstream (and don't have 
time to check for this now). I've just seen there are several new release of 
gnome-power-manager so the problem may already be fixed, will see when I have 
some time.

Eric