Re: [PATCH 1/3] trace-cmd: fix cross-compilation

[Darren Hart <dvhart@linux.intel.com>]

On 12/30/2010 01:02 PM, Bruce Ashfield wrote:
> On Tue, Dec 28, 2010 at 8:17 PM, Darren Hart<dvhart@linux.intel.com>  wrote:
>> The trace-cmd Makefile forces certain variables, such as CC and AR.
>> It was using the host gcc and loader, fix it to use the poky-built
>> cross-compiler and linker.
>>
>> inherit pkgconfig to ensure we don't use the host pkg-config.
>>
>> Remove unecessary variables from the oemake commands, such as ARCH
>> and LD which aren't used by the Makefile.
>>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> CC: Tom Zanussi<tom.zanussi@intel.com>
>
> I actually hacked up the original of this one .. ;)

Right, sorry, forgot to check git blame on this one.

>
>
>> ---
>>   meta/recipes-kernel/trace-cmd/trace-cmd_git.bb |   12 +++++-------
>>   1 files changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd_git.bb b/meta/recipes-kernel/trace-cmd/trace-cmd_git.bb
>> index e375afc..a7eca5f 100644
>> --- a/meta/recipes-kernel/trace-cmd/trace-cmd_git.bb
>> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd_git.bb
>> @@ -2,18 +2,16 @@ DESCRIPTION = "User interface to Ftrace"
>>   LICENSE = "GPL"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>>
>> -PR = r1
>> +PR = r2
>>   PV = "1.0.4+git${SRCPV}"
>>
>> +inherit pkgconfig
>> +
>>   SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git;protocol=git"
>>   S = "${WORKDIR}/git"
>>
>> -
>> -do_compile() {
>> -       oe_runmake ARCH="${ARCH}" CC="${CC}" LD="${LD}" prefix=${prefix}
>> -}
>> +EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}'"
>
> So we've determined that we don't need ARCH anymore ? At one point
> this did. Or is it coming from the pkgconfig inheritance now ?

Good question. My understanding of setting these variables here was to 
override whatever the Makefile was using. This makefile doesn't use ARCH 
at all. Am I missing something about how this is used?

--
Darren

>
> Bruce
>
>>
>>   do_install() {
>> -       oe_runmake ARCH="${ARCH}" CC="${CC}" LD="${LD}" \
>> -                   prefix=${prefix} DESTDIR=${D} install
>> +       oe_runmake CC="${CC}" AR="${AR}" prefix="${prefix}" DESTDIR="${D}" install
>>   }
>> --
>> 1.7.1
>>
>> _______________________________________________
>> poky mailing list
>> poky@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/poky
>>
>
>
>


-- 
Darren Hart
Yocto Linux Kernel