All of lore.kernel.org
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Recent changes break our update scripts, because of getenv_yesno()
Date: Fri, 31 Dec 2010 11:33:39 +0100	[thread overview]
Message-ID: <4D1DB183.9000401@emk-elektronik.de> (raw)

Hello,

in common/image.c:


int getenv_yesno (char *var)
{
	char *s = getenv (var);
	return (s && (*s == 'n')) ? 0 : 1;
}

Is that supposed to return TRUE when the env variable does NOT exist?

Because each TFTP/USB/whatever load of an image will automatically start it!

(and why is such a generic function in image.c?)

Best Regards,
Reinhard

             reply	other threads:[~2010-12-31 10:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-31 10:33 Reinhard Meyer [this message]
2010-12-31 10:41 ` [U-Boot] Recent changes break our update scripts, because of getenv_yesno() Reinhard Meyer
2010-12-31 10:58   ` Stefano Babic
2010-12-31 11:42   ` Wolfgang Denk
2010-12-31 11:54     ` Reinhard Meyer
2010-12-31 17:59       ` Mike Frysinger
2010-12-31 10:55 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D1DB183.9000401@emk-elektronik.de \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.