diff for duplicates of <4D1DF097.1080200@cam.ac.uk> diff --git a/a/1.txt b/N1/1.txt index 035a77c..29f73be 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -236,7 +236,8 @@ rid of this array. > + /* SMBus specifies low byte first, but the SHT21 returns MSB first, > + * so we have to swab16 the values */ > + if (result >= 0) -> + sht21->measurements[meas_idx] > + sht21_convert_raw_value[meas_idx](swab16(result)); +> + sht21->measurements[meas_idx] = +> + sht21_convert_raw_value[meas_idx](swab16(result)); > + } > + sht21->last_update = jiffies; > + sht21->valid = 1; @@ -316,7 +317,7 @@ a user of this, I'd be tempted to just ignore that bit. > + int result; > + char *endptr; > + unsigned long value = simple_strtoul(buf, &endptr, 0); -> + if (endptr = buf || value > 0xff) +> + if (endptr == buf || value > 0xff) > + return -EINVAL; > + > + mutex_lock(&sht21->lock); @@ -507,9 +508,3 @@ Superflous brackets. > +MODULE_AUTHOR("Urs Fleisch <urs.fleisch@sensirion.com>"); > +MODULE_DESCRIPTION("Sensirion SHT21 humidity and temperature sensor driver"); > +MODULE_LICENSE("GPL"); - - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 13b105b..4d9cbbd 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "ref\020101229134511.cc466ac0.urs.fleisch@gmail.com\0" "From\0Jonathan Cameron <jic23@cam.ac.uk>\0" - "Subject\0Re: [lm-sensors] [PATCH] hwmon: driver for Sensirion SHT21 humidity\0" + "Subject\0Re: [PATCH] hwmon: driver for Sensirion SHT21 humidity and temperature sensor\0" "Date\0Fri, 31 Dec 2010 15:02:47 +0000\0" "To\0Urs Fleisch <urs.fleisch@gmail.com>\0" "Cc\0linux-kernel@vger.kernel.org" @@ -247,7 +247,8 @@ "> +\t\t\t/* SMBus specifies low byte first, but the SHT21 returns MSB first,\n" "> +\t\t\t * so we have to swab16 the values */\n" "> +\t\t\tif (result >= 0)\n" - "> +\t\t\t\tsht21->measurements[meas_idx] > +\t\t\t\t sht21_convert_raw_value[meas_idx](swab16(result));\n" + "> +\t\t\t\tsht21->measurements[meas_idx] =\n" + "> +\t\t\t\t sht21_convert_raw_value[meas_idx](swab16(result));\n" "> +\t\t}\n" "> +\t\tsht21->last_update = jiffies;\n" "> +\t\tsht21->valid = 1;\n" @@ -327,7 +328,7 @@ "> +\tint result;\n" "> +\tchar *endptr;\n" "> +\tunsigned long value = simple_strtoul(buf, &endptr, 0);\n" - "> +\tif (endptr = buf || value > 0xff)\n" + "> +\tif (endptr == buf || value > 0xff)\n" "> +\t\treturn -EINVAL;\n" "> +\n" "> +\tmutex_lock(&sht21->lock);\n" @@ -517,12 +518,6 @@ "> +\n" "> +MODULE_AUTHOR(\"Urs Fleisch <urs.fleisch@sensirion.com>\");\n" "> +MODULE_DESCRIPTION(\"Sensirion SHT21 humidity and temperature sensor driver\");\n" - "> +MODULE_LICENSE(\"GPL\");\n" - "\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + "> +MODULE_LICENSE(\"GPL\");" -2684b119530e99e38157e2f30f87963f5e5583e8d53c7011e0ba3846c16f8b61 +523b5d8c487c0e530f4de943066e67bad539f08f6f778e2fa098ff716440bab3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.