From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "Nori, Sekhar" <nsekhar@ti.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH v3] mmc: davinci: add support for SDIO irq handling
Date: Fri, 31 Dec 2010 18:51:12 +0300 [thread overview]
Message-ID: <4D1DFBF0.5030607@mvista.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB593024806DF98@dbde02.ent.ti.com>
Hello.
On 31-12-2010 8:45, Nori, Sekhar wrote:
>>> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
>>> index b643dde..04c2fa4 100644
>>> --- a/drivers/mmc/host/davinci_mmc.c
>>> +++ b/drivers/mmc/host/davinci_mmc.c
>> [...]
>>> @@ -1209,7 +1267,8 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
>>> host->nr_sg = MAX_NR_SG;
>>>
>>> host->use_dma = use_dma;
>>> - host->irq = irq;
>>> + host->mmc_irq = irq;
>>> + host->sdio_irq = platform_get_irq(pdev, 1);
>>>
>>> if (host->use_dma&& davinci_acquire_dma_channels(host) != 0)
>>> host->use_dma = 0;
>>> @@ -1270,6 +1329,13 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
>>> if (ret)
>>> goto out;
>>>
>>> + if (host->sdio_irq != NO_IRQ) {
>> Note that platform_get_irq() will return -EXDEV if the resource is not
>> present. Perhaps you should check for it...
> I checked and got back -ENXIO.
Yes, sorry -- I've mixed them up.
> arch/arm/include/asm/irq.h suggests NO_IRQ
> as the return value. I guess I will just settle for "host->sdio_irq >= 0"
> to check for a valid IRQ number passed.
Right.
> Thanks,
> Sekhar
WBR, Sergei
prev parent reply other threads:[~2010-12-31 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 10:52 [PATCH v3] mmc: davinci: add support for SDIO irq handling Sekhar Nori
2010-12-30 12:42 ` Sergei Shtylyov
2010-12-31 5:45 ` Nori, Sekhar
2010-12-31 10:17 ` Nori, Sekhar
2010-12-31 15:51 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1DFBF0.5030607@mvista.com \
--to=sshtylyov@mvista.com \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-mmc@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.