All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: "David S. Miller" <davem@davemloft.net>
Cc: Ashish Gupta <asg@thelearninglabs.com>,
	Mike Frysinger <vapier@gentoo.org>,
	uclinux-dist-devel@blackfin.uclinux.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Blackfin: Fix spelling in unused code (struct name)
Date: Sun, 02 Jan 2011 16:57:19 +0100	[thread overview]
Message-ID: <4D20A05F.1000802@mail.berlios.de> (raw)
In-Reply-To: <1289164493-9124-1-git-send-email-weil@mail.berlios.de>

Am 07.11.2010 22:14, schrieb Stefan Weil:
> platfrom -> platform
>
> This changes a struct name. The related code is conditionally
> compiled and won't work because the include file linux/gpio-decoder.h
> is missing, so removing this code would be an even better solution.
>
> If the missing include file is added, it must fix the spelling, too.
>
> Cc: Ashish Gupta <asg@thelearninglabs.com>
> Cc: Mike Frysinger <vapier@gentoo.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: uclinux-dist-devel@blackfin.uclinux.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
> arch/blackfin/mach-bf527/boards/tll6527m.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/blackfin/mach-bf527/boards/tll6527m.c 
> b/arch/blackfin/mach-bf527/boards/tll6527m.c
> index 9ec5757..89ae87b 100644
> --- a/arch/blackfin/mach-bf527/boards/tll6527m.c
> +++ b/arch/blackfin/mach-bf527/boards/tll6527m.c
> @@ -193,7 +193,7 @@ static unsigned gpio_addr_inputs[] = {
> GPIO_PG1, GPIO_PH9, GPIO_PH10
> };
>
> -static struct gpio_decoder_platfrom_data spi_decoded_cs = {
> +static struct gpio_decoder_platform_data spi_decoded_cs = {
> .base = EXP_GPIO_SPISEL_BASE,
> .input_addrs = gpio_addr_inputs,
> .nr_input_addrs = ARRAY_SIZE(gpio_addr_inputs),

I did not get any answers for this patch.

Will it be applied to linux git, or should I send a new patch
which removes the non-working conditional code?

Or will the maintainers fix the missing include file?

Kind regards,
Stefan Weil


  reply	other threads:[~2011-01-02 15:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-07 21:14 [PATCH] Blackfin: Fix spelling in unused code (struct name) Stefan Weil
2011-01-02 15:57 ` Stefan Weil [this message]
2011-01-10  7:49 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D20A05F.1000802@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=asg@thelearninglabs.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.