From: Sylwester Nawrocki <snjw23@gmail.com>
To: Sungchun Kang <sungchun.kang@samsung.com>
Cc: linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
s.nawrocki@samsung.com, kgene.kim@samsung.com
Subject: Re: [PATCH] [media] s5p-fimc: modify name of function for uniformity
Date: Sun, 02 Jan 2011 21:32:45 +0100 [thread overview]
Message-ID: <4D20E0ED.5050407@gmail.com> (raw)
In-Reply-To: <1293687343-27424-1-git-send-email-sungchun.kang@samsung.com>
On 12/30/2010 06:35 AM, Sungchun Kang wrote:
> This patch modified function name about add or pop queue.
>
> Reviewed-by Jonghun Han<jonghun.han@samsung.com>
> Signed-off-by: Sungchun Kang<sungchun.kang@samsung.com>
> ---
> This patch is depended on:
> http://git.infradead.org/users/kmpark/linux-2.6-samsung/shortlog/refs/heads/vb2-mfc-fimc
>
> drivers/media/video/s5p-fimc/fimc-capture.c | 2 +-
> drivers/media/video/s5p-fimc/fimc-core.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/s5p-fimc/fimc-capture.c b/drivers/media/video/s5p-fimc/fimc-capture.c
> index 4e4441f..fdef450 100644
> --- a/drivers/media/video/s5p-fimc/fimc-capture.c
> +++ b/drivers/media/video/s5p-fimc/fimc-capture.c
> @@ -155,7 +155,7 @@ int fimc_vid_cap_buf_queue(struct fimc_dev *fimc,
> return ret;
>
> if (test_bit(ST_CAPT_STREAM,&fimc->state)) {
> - fimc_pending_queue_add(cap, fimc_vb);
> + pending_queue_add(cap, fimc_vb);
> } else {
> /* Setup the buffer directly for processing. */
> int buf_id = (cap->reqbufs_count == 1) ? -1 : cap->buf_index;
> diff --git a/drivers/media/video/s5p-fimc/fimc-core.h b/drivers/media/video/s5p-fimc/fimc-core.h
> index 1f1beaa..5bd9d93 100644
> --- a/drivers/media/video/s5p-fimc/fimc-core.h
> +++ b/drivers/media/video/s5p-fimc/fimc-core.h
> @@ -668,7 +668,7 @@ active_queue_pop(struct fimc_vid_cap *vid_cap)
> }
>
> /* Add video buffer to the capture pending buffers queue */
> -static inline void fimc_pending_queue_add(struct fimc_vid_cap *vid_cap,
> +static inline void pending_queue_add(struct fimc_vid_cap *vid_cap,
> struct fimc_vid_buffer *buf)
> {
> list_add_tail(&buf->list,&vid_cap->pending_buf_q);
Nack. However these functions are static it seems more appropriate
to do the opposite, i.e. add a fimc_ prefix to the complementary
functions, as well to those dealing with the active queue.
--
Regards,
Sylwester
prev parent reply other threads:[~2011-01-02 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 5:35 [PATCH] [media] s5p-fimc: modify name of function for uniformity Sungchun Kang
2011-01-02 20:32 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D20E0ED.5050407@gmail.com \
--to=snjw23@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sungchun.kang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.