From: Gabor Juhos <juhosg@openwrt.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Imre Kaloz <kaloz@openwrt.org>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Cliff Holden <Cliff.Holden@atheros.com>,
Kathy Giori <Kathy.Giori@atheros.com>
Subject: Re: [PATCH v4 01/16] MIPS: add initial support for the Atheros AR71XX/AR724X/AR931X SoCs
Date: Mon, 03 Jan 2011 20:35:31 +0100 [thread overview]
Message-ID: <4D222503.1000700@openwrt.org> (raw)
In-Reply-To: <201101022143.13712.florian@openwrt.org>
Hi Florian,
<...>
>> +
>> +static DEFINE_SPINLOCK(ath79_device_reset_lock);
>> +
>> +u32 ath79_cpu_freq;
>> +EXPORT_SYMBOL_GPL(ath79_cpu_freq);
>> +
>> +u32 ath79_ahb_freq;
>> +EXPORT_SYMBOL_GPL(ath79_ahb_freq);
>> +
>> +u32 ath79_ddr_freq;
>> +EXPORT_SYMBOL_GPL(ath79_ddr_freq);
>
> Why not use the Clock API with fixed rates just like how it is done for AR7?
Can you tell me the advantage of that? We can't modify the rates of these
clocks, even we can't {en,dis}able them. Implementing the clock API would add an
unnecessary wrapper layer around the current implementation in my opinion.
Regards,
Gabor
next prev parent reply other threads:[~2011-01-03 19:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 18:56 [PATCH v4 00/16] MIPS: initial support for the Atheros AR71XX/AR724X/AR913X SoCs Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 01/16] MIPS: add initial support for the Atheros AR71XX/AR724X/AR931X SoCs Gabor Juhos
2011-01-02 20:43 ` Florian Fainelli
2011-01-03 19:35 ` Gabor Juhos [this message]
2011-01-02 18:56 ` [PATCH v4 02/16] MIPS: ath79: add GPIOLIB support Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 03/16] MIPS: ath79: utilize the MIPS multi-machine support Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 04/16] MIPS: ath79: add initial support for the Atheros PB44 reference board Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 05/16] MIPS: ath79: add common GPIO LEDs device Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 06/16] watchdog: add driver for the Atheros AR71XX/AR724X/AR913X SoCs Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 07/16] MIPS: ath79: add common watchdog device Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 08/16] MIPS: ath79: add common GPIO buttons device Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 09/16] spi: add SPI controller driver for the Atheros AR71XX/AR724X/AR913X SoCs Gabor Juhos
2011-01-02 18:56 ` Gabor Juhos
2011-01-03 17:02 ` Grant Likely
2011-01-03 17:02 ` Grant Likely
2011-01-04 12:56 ` Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 10/16] MIPS: ath79: add common SPI controller device Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 11/16] USB: ehci: add workaround for Synopsys HC bug Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 12/16] USB: ehci: add bus glue for the Atheros AR71XX/AR724X/AR913X SoCs Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 13/16] USB: ohci: add bus glue for the Atheros AR71XX/AR7240 SoCs Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 14/16] MIPS: ath79: add common USB Host Controller device Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 15/16] MIPS: ath79: add initial support for the Atheros AP81 reference board Gabor Juhos
2011-01-02 18:56 ` [PATCH v4 16/16] MIPS: ath79: add common WMAC device for AR913X based boards Gabor Juhos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D222503.1000700@openwrt.org \
--to=juhosg@openwrt.org \
--cc=Cliff.Holden@atheros.com \
--cc=Kathy.Giori@atheros.com \
--cc=florian@openwrt.org \
--cc=kaloz@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=lrodriguez@atheros.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.