Re: [PATCH v3, Part2, 3/3] udev: Add nokiacdma device

[Dara Spieker-Doyle <dara.spieker-doyle@nokia.com>]

[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]

Hi Denis

On 12/22/2010 06:23 PM, ext Denis Kenzior wrote:
> Hi Dara,
>
> On 12/21/2010 01:23 PM, Dara Spieker-Doyle wrote:
>> ---
>>   plugins/udev.c |   21 +++++++++++++++++++++
>>   1 files changed, 21 insertions(+), 0 deletions(-)
>>
>> diff --git a/plugins/udev.c b/plugins/udev.c
>> index 255755e..9447e5c 100644
>> --- a/plugins/udev.c
>> +++ b/plugins/udev.c
>> @@ -449,6 +449,25 @@ static void add_isi(struct ofono_modem *modem,
>>   	ofono_modem_register(modem);
>>   }
>>
>> +static void add_nokiacdma(struct ofono_modem *modem,
>> +					struct udev_device *udev_device)
>> +{
>> +	const char *devnode;
>> +	int registered;
>> +
>> +	DBG("modem %p", modem);
>> +
>> +	devnode = udev_device_get_devnode(udev_device);
>> +
>> +	registered = ofono_modem_get_integer(modem, "Registered");
>> +	if (registered != 0)
>> +		return;
>> +
>> +	ofono_modem_set_string(modem, "Device", devnode);
>> +	ofono_modem_set_integer(modem, "Registered", 1);
>> +	ofono_modem_register(modem);
>
> This looks a little fishy to me.  How many ttys are created when this
> device is plugged in?  Is it really just one or are you relying on luck
> to select the right tty?
>
When the current nokiacdma (Nokia 7205) device is plugged in there is 
only one TTY created.

Thanks
Dara