From: Mathias Lafeldt <misfire@debugon.org>
To: git <git@vger.kernel.org>
Cc: paulus@samba.org
Subject: BUG: gitk fails to parse 1.7.4-rc0 version string
Date: Tue, 04 Jan 2011 13:44:54 +0100 [thread overview]
Message-ID: <4D231646.5080005@debugon.org> (raw)
Looks like gitk doesn't like the "-rc0" suffix.
$ git --version
git version 1.7.4-rc0
$ gitk
Error in startup script: expected version number but got "1.7.4-rc0"
while executing
"package vcompare $git_version "1.6.6.2""
(file "/usr/local/bin/gitk" line 1)
I temporarily fixed it by hard-coding the version string:
diff --git a/gitk-git/gitk b/gitk-git/gitk
index e82c6bf..367446e 100644
--- a/gitk-git/gitk
+++ b/gitk-git/gitk
@@ -11581,7 +11581,7 @@ if {![info exists have_ttk]} {
set use_ttk [expr {$have_ttk && $want_ttk}]
set NS [expr {$use_ttk ? "ttk" : ""}]
-set git_version [join [lrange [split [lindex [exec git version] end] .]
0 2] .]
+set git_version "1.7.4"
set show_notes {}
if {[package vcompare $git_version "1.6.6.2"] >= 0} {
-Mathias
next reply other threads:[~2011-01-04 12:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 12:44 Mathias Lafeldt [this message]
2011-01-07 0:42 ` [PATCH] gitk: Take only numeric version components when computing $git_version Anders Kaseorg
2011-01-11 13:46 ` Mathias Lafeldt
2011-01-13 19:22 ` Jonathan Nieder
2011-01-18 9:12 ` Mathias Lafeldt
2011-01-18 10:47 ` Paul Mackerras
2011-01-18 21:26 ` Junio C Hamano
2011-01-19 9:35 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D231646.5080005@debugon.org \
--to=misfire@debugon.org \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.