From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/1] phonesim: add null text string case
Date: Tue, 04 Jan 2011 10:55:14 -0600 [thread overview]
Message-ID: <4D2350F2.1090905@gmail.com> (raw)
In-Reply-To: <1294047790-2465-2-git-send-email-jeevaka.badrappan@elektrobit.com>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
Hi Jeevaka,
On 01/03/2011 03:43 AM, Jeevaka Badrappan wrote:
> ---
> src/qsimcommand.cpp | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
>
I applied this patch, however:
> + if ( str.isEmpty() && ( options & QSimCommand::EncodeEmptyStrings ) == 0 ) {
> + // Special form for empty strings.
> + binary += (char)tag;
> + binary += (char)0x01;
> + binary += (char)options;
This part was working by accident. options does not necessarily map to
a valid dcs used by the Text data object. I fixed this in a follow on
commit.
> + return;
> + }
> int schemeMask = ((tag & 0xFF00) >> 8); // For USSD string output.
> if ( ( options & QSimCommand::UCS2Strings ) == 0 ) {
> QTextCodec *gsm = QAtUtils::codec( "gsm-noloss" );
Regards,
-Denis
prev parent reply other threads:[~2011-01-04 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 9:43 [PATCH 0/1] Add null text string case to phonesim Jeevaka Badrappan
2011-01-03 9:43 ` [PATCH 1/1] phonesim: add null text string case Jeevaka Badrappan
2011-01-04 16:55 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2350F2.1090905@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.