From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v2, 6/7] test: Add CDMA SMS Support
Date: Tue, 04 Jan 2011 15:25:15 -0600 [thread overview]
Message-ID: <4D23903B.2030109@gmail.com> (raw)
In-Reply-To: <1292976149-15598-7-git-send-email-lei.2.yu@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
Hi Lei,
On 12/21/2010 06:02 PM, Lei Yu wrote:
> ---
> Makefile.am | 6 ++-
> unit/test-cdmasms.c | 137 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 142 insertions(+), 1 deletions(-)
> create mode 100644 unit/test-cdmasms.c
>
This one looks fine but have you considered using g_test_add_data_func
instead of g_test_add_func? That makes it much easier to add new tests...
Regards,
-Denis
next prev parent reply other threads:[~2011-01-04 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 0:02 [PATCH v2, 6/7] test: Add CDMA SMS Support Lei Yu
2011-01-04 21:25 ` Denis Kenzior [this message]
2011-01-05 17:57 ` Lei Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D23903B.2030109@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.