From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PaOOZ-0001yf-Un for mharc-grub-devel@gnu.org; Wed, 05 Jan 2011 03:06:59 -0500 Received: from [140.186.70.92] (port=33422 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PaOOW-0001yR-1G for grub-devel@gnu.org; Wed, 05 Jan 2011 03:06:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PaOOU-00069L-4r for grub-devel@gnu.org; Wed, 05 Jan 2011 03:06:56 -0500 Received: from mail-ww0-f49.google.com ([74.125.82.49]:37631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PaOOU-000693-0H for grub-devel@gnu.org; Wed, 05 Jan 2011 03:06:54 -0500 Received: by wwb17 with SMTP id 17so15628770wwb.30 for ; Wed, 05 Jan 2011 00:06:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=F1M7NVlNKFlxZSVBLv/6JnBPz9F7ZkufXvRYSwb9yms=; b=TTI478l4zz+TsprW1TauW6hCI77+LcGAX3eNnbUl0N0QuNxSLxQc1iqKv6PjdtLpHw YPXeavJ3xzEAcvj0vAAt7saKkEOK1cq14pq693piIof9MFU+ETcE78Pbdw4ZYMBJypOU hV6hJujmDMmMrgDss/jxH+jKG+2fQeNeYBVdo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=w1uh+LmXGcRTalE/0SJWem6pbJIO6XB+0YVOqiMEo04019lFGuu3vMS3cO5Ez7AdfD 6/saty1/FQOM+fVskogBzvamFsyRM5Tj55vITozj0W/ccgg00j+7OY+4tupzr6HCGS4l LOqhwHUnMMT4THm4hIVuLoPUcGVSrwmuMJ6Q8= Received: by 10.216.46.135 with SMTP id r7mr26177658web.21.1294214813107; Wed, 05 Jan 2011 00:06:53 -0800 (PST) Received: from debian.bg45.phnet (143-7.77-83.cust.bluewin.ch [83.77.7.143]) by mx.google.com with ESMTPS id o51sm11000781wes.15.2011.01.05.00.06.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 05 Jan 2011 00:06:52 -0800 (PST) Message-ID: <4D242690.3000609@gmail.com> Date: Wed, 05 Jan 2011 09:06:40 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Icedove/3.0.11 MIME-Version: 1.0 To: grub-devel@gnu.org References: <201101050558.p055wvGo052896@m5p.com> In-Reply-To: <201101050558.p055wvGo052896@m5p.com> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig6AC67361A93706993B6D8DE1" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Small PIC Fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jan 2011 08:06:58 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6AC67361A93706993B6D8DE1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/05/2011 06:58 AM, ehem+grub@m5p.com wrote: > Perhaps not the biggest deal, but I do like to get low-hanging fixes ou= t > of the way if they appear. > > One very significant item I found. It appears GCC is fine with %rbx bei= ng > clobbered when building PIC in 64-bit mode, even though it has problems= > with %ebx being clobbered when building PIC in 32-bit mode. > > =20 This patch only increases the number of possible ways preprocessor defines can be resolved, which in turn increases the maintenance cost. Restoring %ebx/%rbx unconditionally is cheap. Maintaining exponentially growing number of the way #if's can be resolved isn't. I don't see any problem to enduser with these 2 small instructions always being there. > One other item I did notice. Are there really any processors in the amd= 64 > class that *don't* support CPUID? I'd like to hardcode > grub_cpu_is_cpuid_supported() to return 1 if __x86_64__ is defined, but= > I'm a tad worried I'll be unpleasantly surprised. > > =20 Similar problems. Maintaining something that is always the same is easier than something with loads of #if's. Rule of thumb is: "if it works and your improvement isn't visible to any enduser, don't touch it". > =20 > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig6AC67361A93706993B6D8DE1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk0kJpAACgkQNak7dOguQgmbAQEAwhkarNfclDG0/48HQNXnN/8R iHHROnSmEGilDw4C4cgBALRRSfrm8R8N/FSZ1hCLJxqavjdzHuLe1XEIsEzAStfY =Dx98 -----END PGP SIGNATURE----- --------------enig6AC67361A93706993B6D8DE1--