From: Avi Kivity <avi@redhat.com>
To: Nadav Har'El <nyh@math.technion.ac.il>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add VMX cpuid feature to qemu64
Date: Wed, 05 Jan 2011 10:32:01 +0200 [thread overview]
Message-ID: <4D242C81.5000604@redhat.com> (raw)
In-Reply-To: <20110105081737.GA23681@fermat.math.technion.ac.il>
On 01/05/2011 10:17 AM, Nadav Har'El wrote:
> On Tue, Jan 04, 2011, Alexander Graf wrote about "Re: [Qemu-devel] [PATCH] Add VMX cpuid feature to qemu64":
> > If qemu-kvm still uses the "qemu64" type, that's plainly a bug :). It really should use -cpu kvm64 / kvm32 as default.
>
> When I run qemu-kvm's qemu-system-x86_64, and look at the CPU I get in the
> guest, I the CPU is clearly "QEMU Virtual CPU version 0.13.50" (qemu64) and
> not "Common KVM processor" (kvm64) the "-enable-kvm" option doesn't appear to
> change anything. Could this have always been a bug, which remained hidden
> in plain sight? :-)
>
> If I send a patch to default to kvm64, not qemu64, when KVM is being used,
> would that be acceptable by all parties involved (KVM people and QEMU people)?
>
The intent of kvm64/qemu64 is to provide some feature stability, so that
when you run a guest with those cpu types, you get something expected.
So adding to them isn't a good idea.
I think we'd be fine with -cpu host and -cpu qemu64,+vmx enabling vmx
support.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-01-05 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 15:06 [Qemu-devel] [PATCH] Add VMX cpuid feature to qemu64 Nadav Har'El
2011-01-04 15:53 ` Alexander Graf
2011-01-04 21:39 ` Nadav Har'El
2011-01-04 21:55 ` Alexander Graf
2011-01-05 8:17 ` Nadav Har'El
2011-01-05 8:32 ` Avi Kivity [this message]
2011-01-05 8:50 ` Nadav Har'El
2011-01-05 9:06 ` Avi Kivity
2011-01-05 9:22 ` Nadav Har'El
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D242C81.5000604@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=nyh@math.technion.ac.il \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.