From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Jones Subject: Re: [PATCH] Use a better comparitor for scsi vendor/model table matching. Date: Wed, 05 Jan 2011 11:50:09 -0500 Message-ID: <4D24A141.70105@redhat.com> References: <1294241995-14270-1-git-send-email-pjones@redhat.com> <1294245387.15356.11.camel@mulgrave.site> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51695 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751983Ab1AEQuO (ORCPT ); Wed, 5 Jan 2011 11:50:14 -0500 In-Reply-To: <1294245387.15356.11.camel@mulgrave.site> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Tejun Heo , Linux SCSI On 01/05/2011 11:36 AM, James Bottomley wrote: > On Wed, 2011-01-05 at 10:39 -0500, Peter Jones wrote: >> Previously we were using strncmp in order to avoid having to include >> whitespace in the devlist, but this means "HSV1000" matches a device >> list entry that says "HSV100", which is wrong. This patch adds >> scsi_dh_strcmp(), which checks that any trailing characters in string 2 >> are the pad character 0x20. > > Hmm, the cockup comes from dh rolling its own comparators. Could you > just convert it to use the standard ones in scsi_devinfo.c? There's an > example of how to do this in scsi_transport_spi.c Oh, sure. Thanks for the pointer. -- Peter THE MAGIC WORDS ARE SQUEAMISH OSSIFRAGE