From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <4D24D218.3070709@domain.hid> Date: Wed, 05 Jan 2011 21:18:32 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4D23435B.70603@domain.hid> <4D2379E7.6050307@domain.hid> <201101052040.24049.kisda@domain.hid> <4D24CCB1.30305@domain.hid> <4D24CF69.8040809@domain.hid> In-Reply-To: <4D24CF69.8040809@domain.hid> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig87325216692432FAAB38FFA9" Sender: jan.kiszka@domain.hid Subject: Re: [Xenomai-help] RFC: 16550A pci serial board support List-Id: Help regarding installation and common use of Xenomai List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gilles Chanteperdrix Cc: xenomai@xenomai.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig87325216692432FAAB38FFA9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 05.01.2011 21:07, Gilles Chanteperdrix wrote: > Jan Kiszka wrote: >> Am 05.01.2011 20:40, Stefan Kisdaroczi wrote: >>> Am Dienstag 04 Januar 2011, 20:49:59 schrieben Sie: >>>> Stefan Kisdaroczi wrote: >>>>> Hi, >>>>> >>>>> the attached patch adds pci support to the 16550A serial driver. I = have >>>>> a Moxa CP-132 board and the first tests are looking good. If there = is a >>>>> chance to get the patch applied I kindly request you to review it. = I'll >>>>> add support for more Moxa boards if there is a interest to apply th= e >>>>> patch. >>>>> >>>>> thanks >>>>> Stefan >>>> Looks fine to me, however, nit-picking a bit, could we do this diffe= rently: >>> new patches attached. >>> >> >> Looks good to me as well except for a minor white space damage: >> >>> +static int __devinit rt_16550_pci_probe( struct pci_dev *pdev,= >> ^^^^^^^ >> >> I have one further suggestion which can be done on top: The RTDM_IRQTY= PE >> flags should be customized as well. So far we assume edge-type devices= , >> but PCI is level-triggered. Requesting edge works, but is suboptimal. >=20 > Well, on vanilla linux, the edge handler does not mask the interrupt > line before invoking the handler, so, using the edge handler for level > interrupts should not work and lock-up (except if IRQF_DISABLED is > passed, which should now be the default, OK). IRQF_DISABLED is a (soon to be removed) nop these days, all handlers are called with interrupts disabled. >=20 > Anyway, is a driver the right place to pass these flags? Since the > interrupt controller pins to which the PCI interrupts are wired really > depends on the board more than on the device driver. >=20 I know. But can we always obtain the required information from Linux? If Xenomai could set the right types automatically, that would be much better of course. Jan --------------enig87325216692432FAAB38FFA9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk0k0hgACgkQitSsb3rl5xQfyQCeP1P0jkdk71WHCQtg6GsoxjA/ GeQAnjF8VeMCUfQ2QvZ5QJBFZukFX/zX =um4D -----END PGP SIGNATURE----- --------------enig87325216692432FAAB38FFA9--