From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <4D24D4CE.6030600@domain.hid>
Date: Wed, 05 Jan 2011 21:30:06 +0100
From: Jan Kiszka <jan.kiszka@domain.hid>
MIME-Version: 1.0
References: <4D20D7A7.2090003@domain.hid> <4D21A5CF.9000107@domain.hid>
	<4D24D30E.7060108@domain.hid> <4D24D3C0.8080205@domain.hid>
In-Reply-To: <4D24D3C0.8080205@domain.hid>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig41C865522FEF2DC0E62D4BC3"
Sender: jan.kiszka@domain.hid
Subject: Re: [Xenomai-core] Build issue with rtcan and I-pipe for linux
	2.6.36 on powerpc.
List-Id: Xenomai life and development <xenomai.xenomai.org>
List-Unsubscribe: <https://mail.gna.org/options/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
List-Archive: </public/xenomai-core>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-core-request@domain.hid>
List-Subscribe: <https://mail.gna.org/listinfo/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: Wolfgang Grandegger <wg@domain.hid>, Xenomai core <Xenomai-core@domain.hid>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig41C865522FEF2DC0E62D4BC3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Am 05.01.2011 21:25, Gilles Chanteperdrix wrote:
> Jan Kiszka wrote:
>> Am 03.01.2011 11:32, Wolfgang Grandegger wrote:
>>> Hi Gilles,
>>>
>>> the attached patch fixes the issue.
>>>
>>
>> Nothing critical, but I think we should consistently wrap the other wa=
y
>> around
>>
>> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,36)
>> #define platform_device of_device
>> #endif
>>
>> and update the users to the new style.
>=20
> Err... Am I missing the obvious here? If you include
> <linux/platform_device.h> on powerpc you then get a massive mess prior
> to 2.6.36.

Maybe this is an exception, don't know the powerpc details, but
generally our drivers should be written according to latest (supported)
kernel APIs and then extended/wrapped/etc. to compile with older
versions as well.

Jan


--------------enig41C865522FEF2DC0E62D4BC3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk0k1M4ACgkQitSsb3rl5xSBRACg6VxVQjbkyFGpSuHGWy2Um3f6
dBEAn3fL0upKuG7Nb8t1xoqJ9Y/z3yQi
=RhuY
-----END PGP SIGNATURE-----

--------------enig41C865522FEF2DC0E62D4BC3--