From: Saul Wold <sgw@linux.intel.com>
To: Jessica Zhang <jessica.zhang@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/1] single patch for new adt-installer feature
Date: Wed, 05 Jan 2011 14:04:50 -0800 [thread overview]
Message-ID: <4D24EB02.7000807@linux.intel.com> (raw)
In-Reply-To: <cover.1294126930.git.jessica.zhang@intel.com>
On 01/03/2011 11:42 PM, Jessica Zhang wrote:
> This patch capture the adt-installer feature which includes a recipe file for generating adt-installer tar ball and all the script files and config files for adt-installer.
>
> Create this single patch to avoid the initial adt-install pull request messy situation for review.
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
> Branch: jzhang/installer-feature
> Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jzhang/installer-feature
>
> Thanks,
> Jessica Zhang<jessica.zhang@intel.com>
> ---
>
>
> Liping Ke (1):
> adt-intaller feature implementation, including the bitbake recipe
> file for creating the intaller tar file under /tmp/deploy/sdk, and
> the adt-installer script files and config files
>
> .../installer/adt-installer/adt_installer | 363 ++++++++++++++++++++
> .../installer/adt-installer/adt_installer.conf | 29 ++
> .../adt-installer/opkg/conf/opkg-sdk-i586.conf | 7 +
> .../adt-installer/opkg/conf/opkg-sdk-x86_64.conf | 7 +
> .../adt-installer/scripts/adt_installer_internal | 207 +++++++++++
> .../installer/adt-installer/scripts/data_define | 35 ++
> .../installer/adt-installer/scripts/extract_rootfs | 63 ++++
> .../installer/adt-installer/scripts/util | 99 ++++++
> .../installer/adt-installer_1.0.bb | 61 ++++
Liping,
I notice that you have GPLv2 Headers in the scripts, but the .bb file
refers to a MIT and the Poky main license, you should probably change
these scripts to point use MIT Headers and copyright should be 2010-2011.
You should not be exposing internal intel host information in the .conf
files, maybe you can use the autobuilder repos instead of an internal on
since outside people will use this code also.
I am not sure I like the idea of /opt/poky being hardcoded, will this be
addressed in the future? I think that /opt/poky is still hard-coded in
some of the tools, but I hope this will be changing in the future, so
more of a heads up.
Sau!
> 9 files changed, 871 insertions(+), 0 deletions(-)
> create mode 100755 meta/recipes-devtools/installer/adt-installer/adt_installer
> create mode 100644 meta/recipes-devtools/installer/adt-installer/adt_installer.conf
> create mode 100644 meta/recipes-devtools/installer/adt-installer/opkg/conf/opkg-sdk-i586.conf
> create mode 100644 meta/recipes-devtools/installer/adt-installer/opkg/conf/opkg-sdk-x86_64.conf
> create mode 100755 meta/recipes-devtools/installer/adt-installer/scripts/adt_installer_internal
> create mode 100644 meta/recipes-devtools/installer/adt-installer/scripts/data_define
> create mode 100755 meta/recipes-devtools/installer/adt-installer/scripts/extract_rootfs
> create mode 100644 meta/recipes-devtools/installer/adt-installer/scripts/util
> create mode 100644 meta/recipes-devtools/installer/adt-installer_1.0.bb
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
next prev parent reply other threads:[~2011-01-05 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 7:42 [PATCH 0/1] single patch for new adt-installer feature Jessica Zhang
2011-01-04 7:21 ` [PATCH 1/1] adt-intaller feature implementation, including the bitbake recipe file for creating the intaller tar file under /tmp/deploy/sdk, and the adt-installer script files and config files Liping Ke
2011-01-05 22:04 ` Saul Wold [this message]
2011-01-06 1:19 ` [PATCH 0/1] single patch for new adt-installer feature Ke, Liping
2011-01-07 3:06 ` Ke, Liping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D24EB02.7000807@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=jessica.zhang@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.