From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 5/5] src: remove redundant cast near msg_name
Date: Thu, 06 Jan 2011 03:37:15 +0100 [thread overview]
Message-ID: <4D252ADB.60906@netfilter.org> (raw)
In-Reply-To: <1293752411-12923-6-git-send-email-jengelh@medozas.de>
On 31/12/10 00:40, Jan Engelhardt wrote:
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
> ---
> src/libnfnetlink.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/libnfnetlink.c b/src/libnfnetlink.c
> index fdd7d01..bf511f8 100644
> --- a/src/libnfnetlink.c
> +++ b/src/libnfnetlink.c
> @@ -416,7 +416,7 @@ nfnl_sendiov(const struct nfnl_handle *nfnlh, const struct iovec *iov,
>
> assert(nfnlh);
>
> - msg.msg_name = (struct sockaddr *) &nfnlh->peer;
> + msg.msg_name = &nfnlh->peer;
> msg.msg_namelen = sizeof(nfnlh->peer);
> msg.msg_iov = (struct iovec *) iov;
> msg.msg_iovlen = num;
I hit this here:
libnfnetlink.c: In function ‘nfnl_sendiov’:
libnfnetlink.c:419: warning: assignment discards qualifiers from pointer
target type
I'm going to apply the entire patchset, would you send me a patch for
this minor glitch?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-01-06 2:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 23:40 libnfnetlink: build improvements Jan Engelhardt
2010-12-30 23:40 ` [PATCH 1/5] build: remove unused LIBTOOL_DEPS Jan Engelhardt
2010-12-30 23:40 ` [PATCH 2/5] build: use -Wall across the entire source Jan Engelhardt
2010-12-30 23:40 ` [PATCH 3/5] utils: resolve compiler warning Jan Engelhardt
2010-12-30 23:40 ` [PATCH 4/5] build: implement export symbols Jan Engelhardt
2011-01-06 2:41 ` Pablo Neira Ayuso
2010-12-30 23:40 ` [PATCH 5/5] src: remove redundant cast near msg_name Jan Engelhardt
2011-01-06 2:37 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D252ADB.60906@netfilter.org \
--to=pablo@netfilter.org \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.