RE: [PATCH] Support Mobile Storage controller Interface

RE: [PATCH] Support Mobile Storage controller Interface

[Kukjin Kim]

Jaehoon Chung wrote:
>
> I tried to use mobile storage with sdhci-controller, but bit controlling
is
> too many different
> So need Mobile Storage controller.
> 
> I tested only 8-bit buswidth. It's working well...i think performance
> didn't ensure yet.
> It should be add DDR feature.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/mmc/host/Kconfig  |   12 +
>  drivers/mmc/host/Makefile |    1 +
>  drivers/mmc/host/mshci.c  | 1499
> +++++++++++++++++++++++++++++++++++++++++++++
>  drivers/mmc/host/mshci.h  |  364 +++++++++++
>  4 files changed, 1876 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mmc/host/mshci.c
>  create mode 100644 drivers/mmc/host/mshci.h
> 
(Cc'ed regarding engineer in my team)

Wow, almost same driver is in my team's git tree except
author(MODULE_AUTHOR) and small fix.
(git://git.kernel.org/pub/scm/linux/kernel/git/kki_ap/linux-2.6-samsung.git)

Both have same comments...and in addition, same typo!!! :-(

Actually, we had a plan to submit it, this driver is under test on board and
we still fixing this now.

I would welcome MMC maintainer, Chris' response(or any other response) about
this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Re: [PATCH] Support Mobile Storage controller Interface

[Jaehoon Chung]

Dear Kukjin Kim

i resent mshci patch..not this version.. 
you want..i would remove this patch..

If i resend the other patch...maybe something should present same thing.
because based-on sdhci.c and DWC mobile storage spec..

i will resend the next week..

Thank you for your opinion and sorry Mr.Kim

Thanks.
Jaehoon Chung

Kukjin Kim wrote:
> Jaehoon Chung wrote:
>> I tried to use mobile storage with sdhci-controller, but bit controlling
> is
>> too many different
>> So need Mobile Storage controller.
>>
>> I tested only 8-bit buswidth. It's working well...i think performance
>> didn't ensure yet.
>> It should be add DDR feature.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  drivers/mmc/host/Kconfig  |   12 +
>>  drivers/mmc/host/Makefile |    1 +
>>  drivers/mmc/host/mshci.c  | 1499
>> +++++++++++++++++++++++++++++++++++++++++++++
>>  drivers/mmc/host/mshci.h  |  364 +++++++++++
>>  4 files changed, 1876 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/mmc/host/mshci.c
>>  create mode 100644 drivers/mmc/host/mshci.h
>>
> (Cc'ed regarding engineer in my team)
> 
> Wow, almost same driver is in my team's git tree except
> author(MODULE_AUTHOR) and small fix.
> (git://git.kernel.org/pub/scm/linux/kernel/git/kki_ap/linux-2.6-samsung.git)
> 
> Both have same comments...and in addition, same typo!!! :-(
> 
> Actually, we had a plan to submit it, this driver is under test on board and
> we still fixing this now.
> 
> I would welcome MMC maintainer, Chris' response(or any other response) about
> this.
> 
> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH] Support Mobile Storage controller Interface

[Kyungmin Park]

On Thu, Jan 6, 2011 at 2:14 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Jaehoon Chung wrote:
>>
>> I tried to use mobile storage with sdhci-controller, but bit controlling
> is
>> too many different
>> So need Mobile Storage controller.
>>
>> I tested only 8-bit buswidth. It's working well...i think performance
>> didn't ensure yet.
>> It should be add DDR feature.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  drivers/mmc/host/Kconfig  |   12 +
>>  drivers/mmc/host/Makefile |    1 +
>>  drivers/mmc/host/mshci.c  | 1499
>> +++++++++++++++++++++++++++++++++++++++++++++
>>  drivers/mmc/host/mshci.h  |  364 +++++++++++
>>  4 files changed, 1876 insertions(+), 0 deletions(-)
>>  create mode 100644 drivers/mmc/host/mshci.c
>>  create mode 100644 drivers/mmc/host/mshci.h
>>
> (Cc'ed regarding engineer in my team)
>
> Wow, almost same driver is in my team's git tree except
> author(MODULE_AUTHOR) and small fix.
> (git://git.kernel.org/pub/scm/linux/kernel/git/kki_ap/linux-2.6-samsung.git)
>
> Both have same comments...and in addition, same typo!!! :-(
>
> Actually, we had a plan to submit it, this driver is under test on board and
> we still fixing this now.

Wow, almost same answer, "we had a plan". To address this one, you or
your team send the patch early to remove duplicated works at our side.
As it doesn't appeared at mainline kernel, we implement the codes from
scratch.

The previous time, I sent the this topic, but there's no response and
no one interested
[RFC] Mobile Storage Host support,
http://www.spinics.net/lists/linux-mmc/msg03595.html

I think we wait for long time doesn't it?

I also welcome other MMC developers opinions.

Thank you,
Kyungmin Park

>
> I would welcome MMC maintainer, Chris' response(or any other response) about
> this.
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>