All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: "Brown, Len" <len.brown@intel.com>
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
	steiner@sgi.com
Subject: ia64 build broken [was: mmotm 2010-12-23-16-58 uploaded]
Date: Thu, 06 Jan 2011 09:27:05 +0100	[thread overview]
Message-ID: <4D257CD9.8060909@gmail.com> (raw)
In-Reply-To: <4D234F8E.7080102@gmail.com>

On 01/04/2011 05:49 PM, Jiri Slaby wrote:
> 16dc39c98a6ca56a27f22f7ac6731d8223237a2e is first bad commit
> commit 16dc39c98a6ca56a27f22f7ac6731d8223237a2e
> Author: Len Brown <len.brown@intel.com>
> Date:   Thu Dec 16 23:12:23 2010 -0500
> 
>     ACPI: use ioremap_cache()
> 
>     Although the temporary boot-time ACPI table mappings
>     were set up with CPU caching enabled, the permanent table
>     mappings and AML run-time region memory accesses were
>     set up with ioremap(), which on x86 is a synonym for
>     ioremap_nocache().
> 
>     Changing this to ioremap_cache() improves performance as
>     seen when accessing the tables via acpidump,
>     or /sys/firmware/acpi/tables.  It should also improve
>     AML run-time performance.
> 
>     No change on ia64.

BTW I've just noted, you actually broke ia64. The code reads like:
   return ioremap(unsigned long phys_addr, unsigned long size);

regards,
-- 
js

  parent reply	other threads:[~2011-01-06  8:27 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-24  0:58 mmotm 2010-12-23-16-58 uploaded akpm
2010-12-24  0:58 ` akpm
2010-12-24 12:15 ` Sedat Dilek
2010-12-24 12:15   ` Sedat Dilek
2010-12-24 13:04   ` Andrew Morton
2010-12-24 13:04     ` Andrew Morton
2010-12-24 17:52 ` [PATCH -mmotm] kptr_restrict: fix build when PRINTK not enabled Randy Dunlap
2010-12-24 17:52   ` Randy Dunlap
2010-12-27  2:13 ` mmotm 2010-12-23-16-58 uploaded Randy Dunlap
2010-12-27  2:13   ` Randy Dunlap
2011-01-04 13:40 ` suspend hangs at platform phase [was: mmotm 2010-12-23-16-58 uploaded] Jiri Slaby
2011-01-04 13:40 ` Jiri Slaby
2011-01-04 16:49   ` Jiri Slaby
2011-01-04 16:49   ` Jiri Slaby
2011-01-04 22:57     ` Rafael J. Wysocki
2011-01-05 21:36       ` Jiri Slaby
2011-01-05 22:39         ` Rafael J. Wysocki
2011-01-05 22:39         ` Rafael J. Wysocki
2011-01-05 22:46           ` Jiri Slaby
2011-01-05 23:28             ` Rafael J. Wysocki
2011-01-06  9:18               ` [PATCH 1/1] PM: fix oops in suspend/hibernate code Jiri Slaby
2011-01-06  9:31                 ` Jiri Slaby
2011-01-06 15:57                 ` Rafael J. Wysocki
2011-01-06 15:57                 ` Rafael J. Wysocki
2011-01-06 16:09                   ` Jiri Slaby
2011-01-06 16:09                   ` Jiri Slaby
2011-01-06 16:31                     ` Jiri Slaby
2011-01-06 16:31                     ` Jiri Slaby
2011-01-06 16:38                     ` Rafael J. Wysocki
2011-01-06 16:38                     ` Rafael J. Wysocki
2011-01-06 21:01                       ` Len Brown
2011-01-06 21:01                       ` Len Brown
2011-01-06  9:24               ` suspend hangs at platform phase [was: mmotm 2010-12-23-16-58 uploaded] Jiri Slaby
2011-01-06  9:24               ` Jiri Slaby
2011-01-06 15:45                 ` Rafael J. Wysocki
2011-01-06 15:45                 ` Rafael J. Wysocki
2011-01-05 23:28             ` Rafael J. Wysocki
2011-01-05 22:46           ` Jiri Slaby
2011-01-05 21:36       ` Jiri Slaby
2011-01-04 22:57     ` Rafael J. Wysocki
2011-01-06  8:27     ` ia64 build broken " Jiri Slaby
2011-01-06  8:27     ` Jiri Slaby [this message]
2011-01-06  8:31       ` [PATCH 1/1] ia64: fix build of ioremap_cache Jiri Slaby
2011-01-06 16:03         ` Len Brown
2011-01-06 16:21           ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D257CD9.8060909@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=steiner@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.