From: Claudio Scordino <claudio@evidence.eu.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: starvik@axis.com, Jesper Nilsson <Jesper.Nilsson@axis.com>,
linux-cris-kernel <linux-cris-kernel@axis.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RS485 on Cris: use global value of TIOCSRS485
Date: Thu, 06 Jan 2011 17:58:16 +0100 [thread overview]
Message-ID: <4D25F4A8.7050702@evidence.eu.com> (raw)
In-Reply-To: <20110106133455.2f6175c6@lxorguk.ukuu.org.uk>
Il 06/01/2011 14:34, Alan Cox ha scritto:
>> With this patch, TIOCSRS485 gets the same value across all
>> architectures, making maintenance and portability of user-level code
>> easier.
>
> I don't see why this is worth doing - no application code should ever
> hardcode the value.
I'm afraid this is true only in a theoretical world. But I hope I'm
wrong.
Actually, I can't see any reason to keep different values of TIOCSRS485
in the kernel code when we can have a single value across all
architectures.
But I trust your judgment: if you say it's not worth doing, let's
avoid it.
Many thanks,
Claudio
prev parent reply other threads:[~2011-01-06 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 8:25 [PATCH] RS485 on Cris: use global value of TIOCSRS485 Claudio Scordino
2011-01-06 13:34 ` Alan Cox
2011-01-06 16:58 ` Claudio Scordino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D25F4A8.7050702@evidence.eu.com \
--to=claudio@evidence.eu.com \
--cc=Jesper.Nilsson@axis.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.